refactor: Use MakeBasicObject
#871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExE-Boss
force-pushed
the
refactor/explicit-exotics
branch
from
77f5556 to
85dc069
Compare
domenic
pushed a commit
that referenced
this pull request
Jul 7, 2020
This is a follow-up to #871. Changing the [[SetPrototypeOf]] method of the result of OrdinaryObjectCreate goes against the intention of separating OrdinaryObjectCreate and MakeBasicObject, so this fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the WebIDL interface object creation algorithms to use the
MakeBasicObjectabstract operation that was introduced by @domenic in tc39/ecma262#1460.Preview | Diff