-
Notifications
You must be signed in to change notification settings - Fork 173
Use Bikeshed’s algorithm construct. #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not a big fan of this personally. Having algorithms always be nice numbered lists helps me immensely when reading and understanding. |
OK. There's a lot of single step algorithms which are folded into prose, e.g.: most IDL to ES type mappings. Would you want those fixed at some point? I don't care either way, but I'd like consistency in the spec. |
Ah interesting point. I think fixing those would be good, yeah. |
ad67615
to
366b1da
Compare
OK, this is now ready to be reviewed. |
Github can't show all the changes :( You might need to send this in chunks? |
Actually, nm. Can look at the commits individually. |
Folks, it would really help if someone actually reviewed the following commits:
These are all bugs in the spec uncovered by using Bikeshed's algorithm construct. It shouldn't take a lot of your time, but would allow me to land this commit before I have to handle a bunch of merge conflicts. Thanks. |
Those four commits look fine to me, but I'd kinda prefer if we used « » over prose-allocation of a List. |
This PR:
<div algorithm>
,<dfn>
,turns single step algorithms (e.g.return false
) to prose.This PR is too big to be apprehended as a whole in GitHub, however it's split into explicitly named commits.
The first commit is just a markup change, as shown by its HTML diff.
Every following commit is atomic and addresses a particular issue raised by Bikeshed.
Preview | Diff
Per Commit Preview & Diffs
b6b4453
: Preview | Diff w/ Head (2016-10-21 11:03)8d188f5
: Preview | Diff w/ Head | Diff w/ Previous (2016-10-23 06:29)ad0c8fd
: Preview | Diff w/ Head | Diff w/ Previous (2016-10-23 07:50)32b176d
: Preview | Diff w/ Head | Diff w/ Previous (2016-10-23 08:21)8b14740
: Preview | Diff w/ Head | Diff w/ Previous (2016-10-23 08:24)50fc7e9
: Preview | Diff w/ Head | Diff w/ Previous (2016-10-23 08:39)aa81166
: Preview | Diff w/ Head | Diff w/ Previous (2016-10-23 09:11)735054f
: Preview | Diff w/ Head | Diff w/ Previous (2016-10-23 10:02)da785b7
: Preview | Diff w/ Head | Diff w/ Previous (2016-10-23 12:14)6c5dd1b
: Preview | Diff w/ Head | Diff w/ Previous (2016-10-23 12:29)c442f0e
: Preview | Diff w/ Head | Diff w/ Previous (2016-10-23 12:32)Latest (
a605edb
): Preview | Diff w/ Head | Diff w/ Previous (2016-10-25 17:13)