Skip to content

Replace incorrect "async iterable" token to "async_iterable" #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented May 19, 2025

(Will check the below boxes once we have consensus here)

  • At least two implementers are interested (and none opposed):
    • ...
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno: …
    • Node.js: …
    • webidl2.js: …
    • widlparser: …
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@saschanaz
Copy link
Member Author

And this caught a grammar problem:

 The WebIDL grammar is NOT LL(1) due to the following conflicts:
    1. PartialInterfaceMember:
       * "async" (54/58)

Seems we should change the grammar?

@annevk
Copy link
Member

annevk commented May 20, 2025

How widely deployed is this type? I suspect not very if at all? I wouldn't mind making it async_iterable instead if that would help.

cc @lucacasonato

@saschanaz saschanaz changed the title Fix "async iterable" being a single token Replace incorrect "async iterable" token to "async_iterable" Jun 8, 2025
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants