Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: add a URL path concept #812

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Editorial: add a URL path concept #812

merged 2 commits into from
Jan 26, 2024

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 22, 2024

This will be useful for a future version of the Cookies RFC.

Closes #792.


💥 Error: 400 Bad Request 💥

PR Preview failed to build. (Last tried on Jan 26, 2024, 8:37 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

This will be useful for a future version of the Cookies RFC.

Closes #792.
@annevk
Copy link
Member Author

annevk commented Jan 24, 2024

@tabatkins can you help me with the error here? Am I blind to some typo? Thanks!

@annevk
Copy link
Member Author

annevk commented Jan 24, 2024

cc @johannhof

@tabatkins
Copy link
Contributor

Sorry for the delay - the issue is your for="/" on the definition. Bikeshed is a touch inconsistent here, and doesn't allow that value to indicate an empty for on a dfn, only on a link. Remove it (or change it to for=""), and it'll build correctly.

@annevk annevk merged commit 94b8447 into main Jan 26, 2024
2 checks passed
@annevk annevk deleted the url-path branch January 26, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Consider defining "URL path" as a concept
2 participants