Factor out WritableStreamDefaultWriterRelease #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
force-pushed
the
factor-out-ws-release
branch
2 times, most recently
from
de47215 to
36b7a28
Compare
|
Rebased and moved the test to WPT format; would appreciate a quick review :) |
| const writer = ws.getWriter(); | ||
| writer.releaseLock(); | ||
|
|
||
| return writer.closed.then( |
There was a problem hiding this comment.
Maybe use the weird promise_rejects() function from testharness.js? Something like
return promise_rejects(t, 'TypeError', writer.closed, 'closed promise rejects')
.then(promise_rejects(t, 'TypeError', writer.ready, 'ready promise rejects');
There was a problem hiding this comment.
Yeah, but then I would have to write about this much code to test that they're equal (line 96), so I'm not sure it gains much :-/.
|
lgtm. Sorry for delay!!! |
domenic
force-pushed
the
factor-out-ws-release
branch
from
36b7a28 to
cf9f6a9
Compare
This will help with specifying pipeTo, as seen in #512. This also aligns the spec, tests, and reference implementation on sharing a single error object across both closed and ready promises; previously this was untested and the reference implementation did so but the spec did not.
domenic
force-pushed
the
factor-out-ws-release
branch
from
cf9f6a9 to
aa59974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help with specifying pipeTo, as seen in #512. This also aligns the spec, tests, and reference implementation on sharing a single error object across both closed and ready promises; previously this was untested and the reference implementation did so but the spec did not.