Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp MIME type section #36

Merged
merged 18 commits into from
Dec 7, 2017
Merged

Revamp MIME type section #36

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b4a1154
Revamp MIME type section
annevk Oct 6, 2017
d58f25c
minor fixes
annevk Oct 6, 2017
dad0164
Define MIME type records and redo serialization
annevk Oct 10, 2017
46fb1a6
Sigh, handling backslashes is no fun (no wonder it only works in Fire…
annevk Oct 10, 2017
131819f
fix bs
annevk Nov 24, 2017
780c597
don't strip before parameterValue (happens for charset anyway due to …
annevk Nov 24, 2017
6c449ee
step 7 can be skipped due to EOF
annevk Nov 24, 2017
217896d
make less MIME types parse successfully and drop more parameters
annevk Nov 27, 2017
a2bb175
address #46
annevk Nov 28, 2017
941c8a2
Make remainder of the text use MIME type / essence
annevk Nov 28, 2017
52ef890
add byte variants
annevk Nov 28, 2017
2e4bfca
let's not introduce a new magic value
annevk Nov 28, 2017
da8f000
address nits
annevk Nov 29, 2017
115bba5
empty string -> failure is fine after all
annevk Nov 29, 2017
6c42944
one quarter MIME type portion
annevk Nov 29, 2017
33eedbc
Address review feedback
annevk Dec 4, 2017
534a51d
preserve IDs HTML relies on and some that make sense not to break
annevk Dec 4, 2017
3f70580
remove upstreamed ref
annevk Dec 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
let's not introduce a new magic value
  • Loading branch information
@annevk
annevk committed Nov 28, 2017
commit 2e4bfca8c7cf3b255950406ac38d82b4e62e7d39
2 changes: 1 addition & 1 deletion mimesniff.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ that does not contain U+003B (;).
<ol>
<li><p>Remove any leading and trailing <a>ASCII whitespace</a> from <var>input</var>.

<li><p>If <var>input</var> is the empty string, then return missing.
<li><p>If <var>input</var> is the empty string, then null.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return null.

The algorithm's intro should probably mention that null is the failure condition. (Or, use "failure" instead of "null".)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a failure condition.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then what MIME type gets produced?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up removing this. It wasn't needed after all. Initially it was meant to let callers handle that case in a special way, but further inspection revealed that not to be necessary. Not sure why I initially thought it was.


<li><p>Let <var>position</var> be a position variable for <var>input</var>, initially pointing at
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can link position variable to Infra I think

the start of <var>input</var>.
Expand Down