Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: generate the indices more correctly #47

Merged
merged 1 commit into from
Jan 9, 2017

Conversation

domenic
Copy link
Member

@domenic domenic commented Jan 6, 2017

This was noted in whatwg/url#190.

@annevk
Copy link
Member

annevk commented Jan 9, 2017

LGTM, I guess. I don't really like acknowledgments not being the last thing in the document. Especially since we also picked that section to list the license and maintainer. Maybe we should move that to to its own section that can be truly at the end? Not coming up with any good names at the moment though and it would also require a change to the WHATWG Bikeshed template, but perhaps it means we can use the "Editor" line again.

@domenic
Copy link
Member Author

domenic commented Jan 9, 2017

Hmm, I feel the opposite. To me, acknowledgments are way more important than indices and references, and so should appear earlier in the document.

@domenic domenic merged commit 208e4e0 into master Jan 9, 2017
@domenic domenic deleted the fix-indices-vs-main branch January 9, 2017 17:56
@annevk
Copy link
Member

annevk commented Jan 9, 2017

I can agree with acknowledgments, but the stuff tacked onto acknowledgments makes less sense there if it's not last, imo.

@domenic
Copy link
Member Author

domenic commented Jan 9, 2017

Hmm, I see. I don't think that stuff is too crufty, personally, so I'm OK keeping it above the rest.

annevk added a commit to whatwg/fetch that referenced this pull request Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants