Tweak some of the definitions for maps #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes some changes to the map verbiage which were discovered to be helpful while working on whatwg/html#2054. Concretely, it: - Adds an explicit concept of getting - Makes the shorthands for set/remove/exists link to the longhands, instead of defining a second similar term - Changes the IDs and linking texts of the concepts to be shorter and more useful
annevk
reviewed
Nov 17, 2016
| <a>ordered map</a> |map| and key |key|, "|map|[|key|] <dfn export for=map>exists</dfn>". | ||
| <p>An <a>ordered map</a> <dfn export for=map lt=exists|contains>contains an entry with a given | ||
| key</dfn> if there exists a key/value pair with that key. We can also denote this by saying that, | ||
| for an <a>ordered map</a> |map| and key |key|, "|map|[|key|] <a for=map>exists</dfn>". |
There was a problem hiding this comment.
End tag here is wrong. I guess I can fix that.
|
Found another issue when running make, fixed all I think, but would appreciate another look. |
|
Thanks. I should really be running make instead of make remote. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some changes to the map verbiage which were discovered to be helpful while working on whatwg/html#2054. Concretely, it: