Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define implementation-defined #299

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Define implementation-defined #299

merged 3 commits into from
Apr 20, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented Apr 17, 2020

Closes #210.

I noticed that HTML has some instances of UA-defined. That or user-agent-defined might be reasonable alternatives.


Preview | Diff

@annevk
Copy link
Member Author

annevk commented Apr 17, 2020

cc @hober

Copy link

@hober hober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unsatisfying that we have "user agent" plus "implementation-defined", so I'd slightly prefer "user-agent-defined". Note that HTML uses all three of "user-agent-defined", "user-agent defined", and "UA-defined".

Grammar-wise, I'm not sure whether "user-agent-defined" or "user-agent defined" is more correct... honestly I thought it'd be "user agent-defined"? https://english.stackexchange.com/q/2977/242244 seems to lean toward "user-agent-defined" but also points out "user-agent–defined" with an em dash as a clarity-enhancer.

Maybe we should just go with "implementation-defined" to avoid this mess... should we define "implementation" as a synonym for "user agent" perhaps?

infra.bs Outdated Show resolved Hide resolved
infra.bs Show resolved Hide resolved
infra.bs Outdated Show resolved Hide resolved
@annevk annevk requested a review from domenic April 20, 2020 07:17
@annevk annevk merged commit 6ed08d3 into master Apr 20, 2020
@annevk annevk deleted the annevk/implementation-defined branch April 20, 2020 15:01
@domenic
Copy link
Member

domenic commented Apr 20, 2020

Will you work on a follow-up to align HTML to this? :)

@annevk
Copy link
Member Author

annevk commented Apr 20, 2020

Yeah, I was planning to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

"implementation-defined"
3 participants