Skip to content

Conversation

@emilio
Copy link
Contributor

@emilio emilio commented Jul 7, 2022

Fixes #7830

(See WHATWG Working Mode: Changes for more details.)


/infrastructure.html ( diff )
/interaction.html ( diff )

@emilio emilio requested a review from domenic July 7, 2022 17:23
moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 11, 2022
As per:

 * whatwg/html#7830
 * whatwg/html#8087

Replace the internal preventFocusRing with the new flag.

Differential Revision: https://phabricator.services.mozilla.com/D151326

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1765083
gecko-commit: 570b38756541697f8b5c3b8084b5a2fb438eeca9
gecko-reviewers: smaug, pip-reviewers
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 12, 2022
moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 12, 2022
As per:

 * whatwg/html#7830
 * whatwg/html#8087

Replace the internal preventFocusRing with the new flag.

Differential Revision: https://phabricator.services.mozilla.com/D151326

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1765083
gecko-commit: 570b38756541697f8b5c3b8084b5a2fb438eeca9
gecko-reviewers: smaug, pip-reviewers
@domenic domenic added addition/proposal New features or enhancements topic: focus labels Jul 13, 2022
@benface
Copy link

benface commented Jan 4, 2023

@emilio and @domenic – Is focusVisible: false the same as not setting it? I was hoping this option would allow preventing the focus ring from appearing, in cases where the browser heuristics would normally show it.

@emilio
Copy link
Contributor Author

emilio commented Jan 4, 2023

It is not the same, it does allow preventing it.

@benface
Copy link

benface commented Jan 4, 2023

Thanks for the fast response @emilio, I'm glad. Maybe the wording is a bit ambiguous? It only mentions what should happen when it's true.

@emilio
Copy link
Contributor Author

emilio commented Jan 4, 2023

The wording is rather clear IMO: "If it's true or not present but matches heuristic, indicate focus.". Thus, if it's explicitly false, you wouldn't indicate focus. But if you or @domenic have suggestions for clarification then those would be welcome :)

@benface
Copy link

benface commented Jan 4, 2023

Totally right @emilio, my brain is not working too well today. :)

jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition/proposal New features or enhancements topic: focus

Development

Successfully merging this pull request may close these issues.

Proposal: extend FocusOptions to allow specifying :focus-visible behavior.

3 participants