-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matrix to the safelisted schemes list #6320
Conversation
re "millions of users"; here is a tweet with the latest count, 27.6 million matrix.org-visible user IDs, self-reported |
Mozilla is also okay with adding this. It should be quite easy to add test coverage given the existing tests on web-platform-tests. Are you willing to give that a go? Note that you'll also need to sign https://participate.whatwg.org/agreement as per the CI checks. |
By the way, the proposal at matrix-org/matrix-spec-proposals#2312 has been merged, the |
Hello @annevk, and thank you for helping me move this forward.
Yes, I can do that. As a matter of fact, I prepared some a while back, but didn't put them in a PR. They are nothing too fancy, and will likely require separate review.
Technically, I already did so shortly after opening this PR, I am not sure what's needed going forward. I will rebase, amend the commit message and force-push once the tests are ready, maybe that will re-trigger the CI.
|
I don't think we need to actually test the (Agreement appears to be in order, thanks! We'll verify when this is ready to land.) |
The matrix scheme has recently been finalized and is documented at [1]. Matrix is an open and secure communication protocol, designed for an open federation of servers, much like e-mail or xmpp. The Matrix.org foundation [2] is the custodian of the matrix specification, including the scheme linked above. As a neutral party, it will ensure that future iteration of the matrix scheme will remain in line with its stated goals. The federated (possibly later distributed) nature of the Matrix network calls for an URI scheme, which multiple software programs already implement (namely, Matrix clients Fluffychat, Quaternion, and Nheko among others). Multiple web clients (Element, Hydrogen, Fluffychat again) have expressed their interest in registering as matrix protocol handlers. This commits adds the provisional matrix scheme, as provisionally registered at [3]. The Matrix network currently hosts a few million accounts[4], as well as being the instant communication platform of choice for the KDE and Mozilla communities. [1]: matrix-org/matrix-spec-proposals#2312 [2]: https://matrix.org/foundation/ [3]: https://www.iana.org/assignments/uri-schemes/prov/matrix [4]: https://matrix.org/faq/#what-is-the-current-project-status
2377f88
to
135fd68
Compare
Indeed, the test was quite trivial and I had already written it, I must have confused that with something else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine, I'll shorten the commit message quite a bit when landing. Hope that's okay.
That's fine by me, I like commit messages to contain the context and rationale for a change, but that's probably a Linux Kernel tradition, please do as you see fit for that repo :) Thanks for merging! |
… safelisted Matrix scheme, a=testonly Automatic update from web-platform-tests registerProtocolHandler() and the matrix scheme See whatwg/html#6320. -- wpt-commits: 5dbf4d9321fa1f98787367a6d00786addcca7abb wpt-pr: 28565
It has meanwhile been accepted into the HTML standard: whatwg/html#6320
It has meanwhile been accepted into the HTML standard: whatwg/html#6320
This was added to the HTML spec here: whatwg/html#6320 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/DGt2Iz5qidU Fixed: 1169258 Change-Id: Ib768088aae100c827229b463517b9a5650e03dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2848588 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/master@{#883203}
This was added to the HTML spec here: whatwg/html#6320 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/DGt2Iz5qidU Fixed: 1169258 Change-Id: Ib768088aae100c827229b463517b9a5650e03dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2848588 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/master@{#883203} NOKEYCHECK=True GitOrigin-RevId: 70874d235511ce46531b4b217e7eb39ddd7f4029
It has meanwhile been accepted into the HTML standard: whatwg/html#6320
The matrix scheme is currently being finalized and documented at 1.
Matrix is an open and secure communication protocol, designed for an
open federation of servers, much like e-mail or xmpp.
The Matrix.org foundation 2 is the custodian of the matrix specification,
including the soon-to-be-finalized scheme linked above.
As a neutral party, it will ensure that future iteration of the matrix
scheme will remain in line with its stated goals.
The federated (possibly later distributed) nature of the Matrix network calls
for an URI scheme, which multiple software programs already implement
(namely, Matrix clients Fluffychat, Quaternion, and Nheko among others).
Multiple web clients (Element, Hydrogen, Fluffychat again) have
expressed their interest in registering as matrix protocol handlers.
This commits adds the provisional matrix scheme, as provisionally registered
at 3.
The Matrix network currently hosts a few million accounts 4, as well as
being the instant communication platform of choice for the KDE and Mozilla
communities.
I think all of the above makes a strong case for safelisting the scheme, even before browser support. Mozilla having recently migrated from IRC to Matrix offers a strong display of interest in the protocol on their part.
If you are interested in the scheme itself, it is documented in the accepted Matrix Specification Change (MSC) at matrix-org/matrix-spec-proposals#2312
It is noteworthy that there are currently only two implementers of custom protocol handlers, to my knowledge. However, multiple client applications can already act as protocol handlers for that scheme.
Safaridoes not supportregisterProtocolHandler()
(See WHATWG Working Mode: Changes for more details.)
/acknowledgements.html ( diff )
/system-state.html ( diff )