Change how minimum used value for line-height works #5462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcorpan
added
the
needs tests
|
Checking for any opposition -- @smfr @tkent-google |
|
I don't get why this is in HTML not CSS, but OK. |
|
@smfr do you think the definition for the 'line-height' property should define this special case? |
|
I have no objection. |
|
Yeah, this would be monkey patching CSS. It should be clear when implementing line-height from the CSS specification that certain elements can enforce this behavior. It would be cleaner to do this through some element flag that HTML sets and CSS reads to enforce this, or some such. (Edit: to be fair, the status quo had a similar problem, but we should at least file an issue to get this addressed eventually.) cc @whatwg/css |
|
Filed w3c/csswg-drafts#4977 |
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 3, 2022
zcorpan
removed
the
needs tests
zcorpan
force-pushed
the
zcorpan/input-minimum-line-height
branch
from
c6440d4
to
59ad1a4
Compare
|
This should apply to |
|
Fixed. Browser bugs filed also. |
zcorpan
commented
Feb 10, 2022
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 10, 2022
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 10, 2022
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 10, 2022
mattwoodrow
pushed a commit
to mattwoodrow/wpt
that referenced
this pull request
Feb 15, 2022
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 26, 2022
…e=text> and friends, a=testonly Automatic update from web-platform-tests Test how line-height works on <input type=text> and friends See whatwg/html#5462 -- wpt-commits: ac55bfa0f0acb4155db0ac0b4e3245d10b03c48e wpt-pr: 32684
DanielRyanSmith
pushed a commit
to DanielRyanSmith/wpt
that referenced
this pull request
Feb 28, 2022
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 1, 2022
…e=text> and friends, a=testonly Automatic update from web-platform-tests Test how line-height works on <input type=text> and friends See whatwg/html#5462 -- wpt-commits: ac55bfa0f0acb4155db0ac0b4e3245d10b03c48e wpt-pr: 32684
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 8, 2022
…e=text> and friends, a=testonly Automatic update from web-platform-tests Test how line-height works on <input type=text> and friends See whatwg/html#5462 -- wpt-commits: ac55bfa0f0acb4155db0ac0b4e3245d10b03c48e wpt-pr: 32684
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 8, 2022
…e=text> and friends, a=testonly Automatic update from web-platform-tests Test how line-height works on <input type=text> and friends See whatwg/html#5462 -- wpt-commits: ac55bfa0f0acb4155db0ac0b4e3245d10b03c48e wpt-pr: 32684
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5366.
getComputedStyle(which returns used value)(See WHATWG Working Mode: Changes for more details.)
/rendering.html ( diff )