Layering: Implement HostEnqueuePromiseJob #5360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JavaScript specification now uses the HostEnqueuePromiseJob hook, to be implemented by embedders, for enqueuing promises with the host. This allows HTML to avoid its willful violation, and delete an explanation of the motivation for this violation.
domenic
reviewed
Mar 17, 2020
| @@ -91142,65 +91143,29 @@ document.querySelector("button").addEventListener("click", bound); | |||
| user with a mechanism to just close the page entirely, without running any <code | |||
| data-x="event-unload">unload</code> event handlers.</p> | |||
|
|
|||
| <h5>Integration with the JavaScript job queue</h5> | |||
| <h5><dfn>HostEnqueuePromiseJob</dfn>(<var>job</var>, <var>realm</var>)</h5> | |||
There was a problem hiding this comment.
We should preserve both of the old IDs. We do this manually by adding id="" for one, and <span id=""></span> for others. You can find some examples elsewhere in the spec.
There was a problem hiding this comment.
Sorry I'm not following, what old ids are you referring to? EnqueueJob? (Does this comment refer to the HostEnqueuePromiseJob <h5>?)
There was a problem hiding this comment.
I meant the "integration with the JavaScript job queue" and "enqueue job" heading IDs.
I'll push a commit that does this.
domenic
approved these changes
Mar 18, 2020
|
Ah thanks for pushing the ids thing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JavaScript specification now uses the HostEnqueuePromiseJob hook, to
be implemented by embedders, for enqueuing promises with the host. This
allows HTML to avoid its willful violation, and delete an explanation of
the motivation for this violation.
(This supersedes #4722. @littledan and I agreed I'll draft the upstream HTML PR. This PR is based off his; I'd use that PR but I don't have write access to his fork.)
/index.html ( diff )
/infrastructure.html ( diff )
/webappapis.html ( diff )