-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define (schemelessly) same site for origins #5076
Conversation
Helpers with whatwg/url#448.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for doing this work! Just a few nits.
Nits fixed. @annevk any reason to hold off on merging this? I guess maybe we should get all the call site updates lined up beforehand? Or just go for it... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, I have some minor suggestions for improvements.
I'm okay with going for it. I don't really have a list of all callers unfortunately, except for the one in Fetch. |
Follows whatwg/html#5076. See #969 for a potential normative follow-up to change this to use "same site".
Helpers with whatwg/url#448.
/cc @mikewest
I think establishing this for now makes the most sense. We can later work on introducing potential "site" or "schemeless site" concepts directly, but for now, we should get a proper definition of these equality relations, as applied to origins.
/infrastructure.html ( diff )
/origin.html ( diff )