-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
focus: autofocus should work with shadow hosts with delegatesFocus an… #5059
focus: autofocus should work with shadow hosts with delegatesFocus an… #5059
Conversation
…d area elements Fixes whatwg#5027
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. (I pushed some editorial tweaks; please take a look to make sure I didn't mess anything up.)
For anyone else watching, the diff is a bit hard to read, but the essence of it is simple: extract out step 1 of the focusing steps, which translates focus targets into focusable areas, into its own algorithm (named "get the focusable area"). Then, call that from the autofocus algorithm, so that autofocus works on "exotic" cases like <area>
and delegatesFocus
which need that extra translation step.
@rniwa @smaug---- can you confirm that you're up for making autofocus work with <area>
and delegatesFocus
in WebKit and Gecko? In my opinion this is a pretty simple bugfix and I'd like to merge ASAP.
The edit looks great. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(huh, github's reviewing tool really can't deal with this change well)
…and <area>., a=testonly Automatic update from web-platform-tests autofocus: Add tests for delegatesFocus and <area> Follows whatwg/html#5059. -- wpt-commits: 4cfddceea40940f2d8290bb92d081824fe781942 wpt-pr: 20083
…and <area>., a=testonly Automatic update from web-platform-tests autofocus: Add tests for delegatesFocus and <area> Follows whatwg/html#5059. -- wpt-commits: 4cfddceea40940f2d8290bb92d081824fe781942 wpt-pr: 20083
…and <area>., a=testonly Automatic update from web-platform-tests autofocus: Add tests for delegatesFocus and <area> Follows whatwg/html#5059. -- wpt-commits: 4cfddceea40940f2d8290bb92d081824fe781942 wpt-pr: 20083 UltraBlame original commit: c2b6f23092d76bffaa131715c54ec5dfd9009d18
…and <area>., a=testonly Automatic update from web-platform-tests autofocus: Add tests for delegatesFocus and <area> Follows whatwg/html#5059. -- wpt-commits: 4cfddceea40940f2d8290bb92d081824fe781942 wpt-pr: 20083 UltraBlame original commit: c2b6f23092d76bffaa131715c54ec5dfd9009d18
…and <area>., a=testonly Automatic update from web-platform-tests autofocus: Add tests for delegatesFocus and <area> Follows whatwg/html#5059. -- wpt-commits: 4cfddceea40940f2d8290bb92d081824fe781942 wpt-pr: 20083 UltraBlame original commit: c2b6f23092d76bffaa131715c54ec5dfd9009d18
…d area elements
Fixes #5027
(See WHATWG Working Mode: Changes for more details.)
/interaction.html ( diff )