Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic for reflecting IDREF (single or FrozenArray) attributes #3917

Closed
wants to merge 20 commits into from
Closed

Add logic for reflecting IDREF (single or FrozenArray) attributes #3917

wants to merge 20 commits into from

Commits on Mar 30, 2021

  1. Add logic for reflecting IDREF (single) attributes.

    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    d20d68b View commit details
    Browse the repository at this point in the history

  2. Update element and sequence<element> reflection sections

    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    6c993af View commit details
    Browse the repository at this point in the history

  3. Address Anne's comments

    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    45e454c View commit details
    Browse the repository at this point in the history

  4. Source formatting nits

    @domenic
    domenic authored and Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    fcdff87 View commit details
    Browse the repository at this point in the history

  5. More tweaks

    @domenic
    domenic authored and Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    d58b34a View commit details
    Browse the repository at this point in the history

  6. Nullable types and attribute change steps

    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    d405676 View commit details
    Browse the repository at this point in the history

  7. Use FrozenArray; move IDREF parsing step to attribute update steps

    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    ec4438c View commit details
    Browse the repository at this point in the history

  8. Review comments from Anne

    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    d5859bd View commit details
    Browse the repository at this point in the history

  9. Allow elements to be from any less-nested shadow tree

    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    d3ba958 View commit details
    Browse the repository at this point in the history

  10. Do not run attribute change steps if attribute was set via reflection

    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    7350c16 View commit details
    Browse the repository at this point in the history

  11. Be more explicit about checking whether the content attribute was set… 

    … via reflection
    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    6487b47 View commit details
    Browse the repository at this point in the history

  12. Fix typo attrAssociatedElements -> attrAssociatedElement

    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8e27621 View commit details
    Browse the repository at this point in the history

  13. Rework definition of attr-associated element(s) to avoid over-specifying

    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    bda0102 View commit details
    Browse the repository at this point in the history

  14. Address domenic's comments

    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    f6e501f View commit details
    Browse the repository at this point in the history

  15. Editorial tweaks to T? reflection

    @domenic
    domenic authored and Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    63a45e8 View commit details
    Browse the repository at this point in the history

  16. Editorial and slight normative tweaks to FrozenArray<T>? reflection 

    Normative change: previously, if a non-type-compatible element had the ID, and was before a type-compatible element in tree order that also had the ID, then neither would show up in the attr-associated elements. Now, the type-compatible one shows up. This matches the behavior of the T? reflection better.
    @domenic
    domenic authored and Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    3cc73cd View commit details
    Browse the repository at this point in the history

  17. Update based on AOM discussions

    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    003e307 View commit details
    Browse the repository at this point in the history

  18. Remove references to cached attr-elements

    Alice Boxhall committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    ca6d62d View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Revert "Remove references to cached attr-elements" 

    This reverts commit ca6d62d.
    Alice Boxhall committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    228b604 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Return null if the attribute is not present, and empty array instead … 

    …of null if zero values
    Alice Boxhall committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    b2ce057 View commit details
    Browse the repository at this point in the history