Handle the timeupdate/pause/ended events in a single task #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mounirlamouri, care to review? It's not a given that there should only be a single task, and it's somewhat arbitrary how tasks are split in general, but I thought that if had a single queue for events and tasks, this would make sense. |
| with the result and an <span>"<code>AbortError</code>"</span> | ||
| <code>DOMException</code>.</p></li> | ||
| <p>If the <span>media element</span> has still <span>ended playback</span>, and the | ||
| <span>direction of playback</span> is still forwards, and <span |
There was a problem hiding this comment.
I'm not sure if the "still" are meaningful here.
|
lgtm 👍 |
foolip
force-pushed
the
ended-single-task
branch
from
7beecd1 to
003a706
Compare
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
The motivation for this is to have the "still ended playback" bit as a real step, more like how it would be implemented. Drive-by "run the following substeps" for consistency. Follow-up to whatwg#1646 and whatwg#1647.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this is to have the "still ended playback" bit as a
real step, more like how it would be implemented.
Drive-by "run the following substeps" for consistency.
Follow-up to #1646 and #1647.