Allow comments to end with <!--> #1456

zcorpan · 2016-06-22T08:18:04Z

Introduce a new state in the parser to not give a parse error
when a comment ends with "<!-->".

It is common to use conditional comments for legacy IE like this:

<!--[if gt IE 9]><!--> ... <!--<![endif]-->

This regressed in 518d16f.

Fixes #1453.

Introduce a new state in the parser to not give a parse error when a comment ends with " ...  This regressed in 518d16f. Fixes #1453.

zcorpan · 2016-06-22T09:53:13Z

@eel-in-a-hovercraft Thanks for bringing this issue to our attention. Would you like to have your name in the spec's Acknowledgements, and if so under what name?

annevk · 2016-06-22T11:14:09Z

Do we expect more fallout? How many implementations do we have now of the new comment states? I'm a little worried that we are tinkering too much with something that was fairly robust.

sideshowbarker · 2016-06-22T11:18:50Z

Do we expect more fallout?

No. We should have anticipated this one.

User-facing behavior for this has been in the W3C HTML checker getting hit with a dozen requests or more every second, and this is the only unexpected change any users have reported so far.

How many implementations do we have now of the new comment states?

Just one: The parser used by the HTML parser. No browser implementations yet. But it’s only been in the spec for one day so far…

zcorpan · 2016-06-22T14:35:53Z

@sideshowbarker has now implemented this change in https://checker.html5.org/ and AFAICT it now works as expected.
validator/htmlparser@d77bc02
https://checker.html5.org/parsetree/?parser=html5&content=%3C!--%3C!--%3E&submit=Print+Tree

eel-in-a-hovercraft · 2016-06-22T14:57:04Z

Thank YOU. Having my name in the acknowledgements would be great. Put me in
as Marc-André Choquette.

Thanks again.
On Jun 22, 2016 05:53, "Simon Pieters" notifications@github.com wrote:

@eel-in-a-hovercraft https://github.com/eel-in-a-hovercraft Thanks for
bringing this issue to our attention. Would you like to have your name in
the spec's Acknowledgements, and if so under what name?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1456 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AFjj6hnJ0OQ6pJ_rOYm738fGCiFrMlRVks5qOQYPgaJpZM4I7hCM
.

zcorpan · 2016-06-22T16:15:05Z

Awesome, added you. 👍

zcorpan · 2016-06-23T10:31:51Z

I think this is ready to merge.

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456 Differential Revision: https://phabricator.services.mozilla.com/D82000

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456 Differential Revision: https://phabricator.services.mozilla.com/D82000

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456 Differential Revision: https://phabricator.services.mozilla.com/D82000

Allow comments to end with ". It is common to use conditional comments for legacy IE like this:  ...  This regressed in 518d16f. Fixes #1453.

zcorpan added document conformance topic: parser labels Jun 22, 2016

zcorpan assigned sideshowbarker Jun 22, 2016

zcorpan mentioned this pull request Jun 22, 2016

Allow dashes in comments #1356

Merged

zcorpan unassigned sideshowbarker Jun 22, 2016

Add @eel-in-a-hovercraft to acks

4920a1e

zcorpan assigned domenic Jun 23, 2016

domenic merged commit 1633b9a into master Jun 23, 2016

domenic deleted the allow-conditional-comments branch June 23, 2016 16:20

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Dec 5, 2016

Make consecutive hyphens in comments a non-error

3e34c62

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request May 18, 2017

Make consecutive hyphens in comments a non-error

702fec6

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request May 19, 2017

Make consecutive hyphens in comments a non-error

bf3c328

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request May 19, 2017

Make consecutive hyphens in comments a non-error

cd59746

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request May 19, 2017

Make consecutive hyphens in comments a non-error

88097f8

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request May 19, 2017

Make consecutive hyphens in comments a non-error

14d9a75

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Jul 4, 2017

Make consecutive hyphens in comments a non-error

bc75459

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Jul 5, 2017

Make consecutive hyphens in comments a non-error

2017a98

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Jul 7, 2017

Make consecutive hyphens in comments a non-error

5130f63

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Oct 8, 2017

Make consecutive hyphens in comments a non-error

2fed20c

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Oct 8, 2017

Make consecutive hyphens in comments a non-error

19ff2de

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Dec 14, 2017

Make consecutive hyphens in comments a non-error

756b2cb

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Feb 6, 2018

Make consecutive hyphens in comments a non-error

f5478df

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Mar 16, 2018

Make consecutive hyphens in comments a non-error

10b7de0

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Mar 16, 2018

Make consecutive hyphens in comments a non-error

9963a8e

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Mar 16, 2018

Make consecutive hyphens in comments a non-error

4ec3da9

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Nov 16, 2018

Make consecutive hyphens in comments a non-error

e801337

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Dec 15, 2018

Make consecutive hyphens in comments a non-error

1ff4d34

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Dec 17, 2018

Make consecutive hyphens in comments a non-error

fcf810a

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Dec 18, 2018

Make consecutive hyphens in comments a non-error

73d7521

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Jan 15, 2019

Make consecutive hyphens in comments a non-error

4be6499

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Apr 28, 2019

Make consecutive hyphens in comments a non-error

a18e2b2

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Jul 5, 2019

Make consecutive hyphens in comments a non-error

b103432

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Nov 26, 2019

Make consecutive hyphens in comments a non-error

a8afaac

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Jan 15, 2020

Make consecutive hyphens in comments a non-error

311ffb0

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Feb 12, 2020

Make consecutive hyphens in comments a non-error

acb7cbd

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Feb 13, 2020

Make consecutive hyphens in comments a non-error

fda64f4

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Mar 4, 2020

Make consecutive hyphens in comments a non-error

35edf3a

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Apr 23, 2020

Make consecutive hyphens in comments a non-error

2bf78a7

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Apr 24, 2020

Make consecutive hyphens in comments a non-error

29a2645

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Apr 25, 2020

Make consecutive hyphens in comments a non-error

8f45c22

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Jun 18, 2020

Make consecutive hyphens in comments a non-error

01a291c

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Jul 4, 2020

Make consecutive hyphens in comments a non-error

20eaf92

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Jul 4, 2020

Make consecutive hyphens in comments a non-error

375f85f

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Aug 3, 2020

Make consecutive hyphens in comments a non-error

b25f655

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Aug 5, 2020

Make consecutive hyphens in comments a non-error

3ddc80a

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Aug 10, 2020

Make consecutive hyphens in comments a non-error

82ef614

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

sideshowbarker added a commit to validator/htmlparser that referenced this pull request Aug 21, 2020

Make consecutive hyphens in comments a non-error

c22c3fa

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

hsivonen pushed a commit to validator/htmlparser that referenced this pull request Aug 17, 2021

Make consecutive hyphens in comments a non-error

6c06ef8

Also allow `<!-->` at (IE conditional) comment end See whatwg/html#1356 See whatwg/html#1456

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow comments to end with <!--> #1456

Allow comments to end with <!--> #1456

Uh oh!

zcorpan commented Jun 22, 2016 •

edited

Loading

Uh oh!

zcorpan commented Jun 22, 2016

Uh oh!

annevk commented Jun 22, 2016

Uh oh!

sideshowbarker commented Jun 22, 2016

Uh oh!

zcorpan commented Jun 22, 2016

Uh oh!

eel-in-a-hovercraft commented Jun 22, 2016

Uh oh!

zcorpan commented Jun 22, 2016

Uh oh!

zcorpan commented Jun 23, 2016

Uh oh!

Uh oh!

Allow comments to end with <!--> #1456

Allow comments to end with <!--> #1456

Uh oh!

Conversation

zcorpan commented Jun 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zcorpan commented Jun 22, 2016

Uh oh!

annevk commented Jun 22, 2016

Uh oh!

sideshowbarker commented Jun 22, 2016

Uh oh!

zcorpan commented Jun 22, 2016

Uh oh!

eel-in-a-hovercraft commented Jun 22, 2016

Uh oh!

zcorpan commented Jun 22, 2016

Uh oh!

zcorpan commented Jun 23, 2016

Uh oh!

Uh oh!

zcorpan commented Jun 22, 2016 •

edited

Loading