-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add new strings for notRestoredReason for SharedWorker #12086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new strings for notRestoredReason for SharedWorker #12086
Conversation
|
@smaug---- @annevk @rakina could you help to review this change? |
annevk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapping is incorrect. See the guidelines and previous PR of this sort.
Fixed the wrapping, sorry. |
annevk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll leave this to Mozilla to okay as per the prior PRs.
631b2a6 to
e20ae5b
Compare
|
@llannasatoll do you want to file bugs for Gecko and WebKit? Also the Participation check is not green (if your employer has signed, maybe you need to make your org membership public). |
Thanks! I've filed the bugs for Gecko and WebKit, and updated the PR description with the links. Please let me know if there are still any issues with it. |
The existing
sharedworkerstring in notRestoredReason is a general back/forward cache block for pages with SharedWorker. To relax this, we are adding two specific strings:sharedworker-message: Evicts a page from back/forward cache if it receives a message from its SharedWorker while cached.sharedworker-with-no-active-client: Blocks or evicts a page if its connected SharedWorker no longer has active client. This ensures workers do not continue running without any active documents.(See WHATWG Working Mode: Changes for more details.)
/nav-history-apis.html ( diff )