[Draft] Introduce the new menu elements #12011
Draft
+1,158
−367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note there are a couple open questions in the form of TODOs. For example: 1. Should `popovertargetaction` be allowed to target `<menulist>` elements? Probably, but it could use discussion. 2. Should the attribute change steps that react to `popover` attribute mutations "work" on `<menulist>` elements? This effectively makes the explicit `popover` attribute work on `<menulist>` elements, possibly overriding their default popover behavior. This could also use more discussion. (My preference would be to ignore `popover` on `<menulist>` for now).
This commit moves the command/commandfor attributes into their own section,
since they're general to both buttons and menuitem elements. The next steps are:
1. Pull out a shared activation behavior algorithm from the button element,
that defines the command-invoking parts that the two elements have in common
2. Add the three new commands
3. Define the menuitem element, and any menuitem-specific things for the
commands
These are copied from the main button activation steps's popover handling steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
<menubar>,<menulist>, and<menuitem>elements as they appear in Open UI's menu elements proposal: https://open-ui.org/components/menu.explainer/. This includes their integration with popovers, command invokers,<fieldset>and checkability, default styles, and variant default styles for the<menulist>element depending on how it is rendered. What has not been spec'd yet is:orientationattribute's effect on default styles and keyboard navigability<menulist>popovers). But to be consistent with customizable select, we're not planning on specifying the exact keyboard behavior for getting from one menulist to another in a menubar, or traversing through menu items in a menu bar or list. These will be covered by examples, notes, and.optionalWPTscheckedevent integration discussed in What event should fire on checkable menu items? openui/open-ui#1321akey to focus the first menuitem in a menulist that starts with the charactera)This PR is only a draft. It's suitable for stage 2 evaluation of the menu elements proposal tracked by #11729, but has rough edges and non-trivial TODOs. The API shape is just about fully expressed though.
(See WHATWG Working Mode: Changes for more details.)
/dom.html ( diff )
/form-elements.html ( diff )
/grouping-content.html ( diff )
/index.html ( diff )
/indices.html ( diff )
/infrastructure.html ( diff )
/interaction.html ( diff )
/interactive-elements.html ( diff )
/obsolete.html ( diff )
/popover.html ( diff )
/rendering.html ( diff )
/semantics-other.html ( diff )