Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<style> needs to work for disconnected shadow trees #1199

Merged
merged 1 commit into from
May 6, 2016
Merged

<style> needs to work for disconnected shadow trees #1199

merged 1 commit into from
May 6, 2016

Conversation

annevk
Copy link
Member

@annevk annevk commented May 5, 2016

Fixes #1194.

@annevk annevk added the topic: shadow Relates to shadow trees (as defined in DOM) label May 5, 2016
@domenic
Copy link
Member

domenic commented May 5, 2016

LGTM, will let @rniwa sign off.

@rniwa
Copy link

rniwa commented May 5, 2016

r=me (I still don't seem to write write access).

@TakayoshiKochi
Copy link
Member

LGTM

@domenic
Copy link
Member

domenic commented May 6, 2016

@rniwa, not sure what you meant by your comment, but is "r=me" equivalent to "LGTM", or something else?

@rniwa
Copy link

rniwa commented May 6, 2016

yeah, r=me means "reviewed by me".

@domenic domenic merged commit 3210b7c into master May 6, 2016
@domenic domenic deleted the shadow-style-2 branch May 6, 2016 20:38
@hayatoito hayatoito mentioned this pull request Jun 27, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rniwa rniwa

Labels
topic: shadow Relates to shadow trees (as defined in DOM)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annevk @domenic @rniwa @TakayoshiKochi