-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Allow deferring same-origin cross-document commit #11927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
noamr
wants to merge
34
commits into
whatwg:main
Choose a base branch
from
noamr:defer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+320
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"commit a navigate event" is a noop when the navigation is not intercepted in the first place. Instead of calling it and checking for the interception state internally, only call it for intercepted navigations, and rename it to "commit an intercepted navigate event". Also remove internal logic that tests whether the navigation is same-document (intercepted navigations are always same-document).
This specifies a way for authors to defer a same-origin cross-document navigation commit. It exposes: - `navigateEvent.deferCommit(promise)` Allows a listener to the `navigate` event to defer a cross-document commit, without intercepting it. Returns a promise that can be used to clean up any intermediate state. - `navigateEvent.destination.ready` A boolean getter that returns true when the navigation is expected to be instant, i.e. when the destination already has a document and that document is not render-blocked (which by and large would imply prerendering). Closes whatwg#11819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deferred same-origin cross-document commit
This gives a way for authors to defer a same-origin cross-document navigation commit.
The API is used in this way:
See explainer.
Closes #11819
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/index.html ( diff )
/nav-history-apis.html ( diff )