Skip to content

Make option.form use nearest ancestor select #11720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make option.form use nearest ancestor select #11720

wants to merge 2 commits into from

Conversation

josepharhar
Copy link
Contributor

@josepharhar josepharhar commented Sep 29, 2025 •
edited by pr-preview bot
Loading

Now that option elements can be any descendant of a select element, this algorithm needs to look higher than just its parent for a select element.

Fixes #11708

(See WHATWG Working Mode: Changes for more details.)

/form-elements.html ( diff )

@josepharhar
Make option.form use nearest ancestor select
970d974 
Now that option elements can be any descendant of a select element, this
algorithm needs to look higher than just its parent for a select
element.

Fixes whatwg#11708
@josepharhar josepharhar mentioned this pull request Sep 29, 2025
Open
annevk
annevk reviewed Sep 30, 2025
View reviewed changes
@annevk annevk added the topic: select The <select> element label Sep 30, 2025
zcorpan
zcorpan approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@zcorpan zcorpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with annevk's suggested change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

@zcorpan zcorpan zcorpan approved these changes

Assignees
No one assigned
Labels
topic: select The <select> element
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

option element form IDL attribute works incorrectly
3 participants
@josepharhar @zcorpan @annevk