-
Notifications
You must be signed in to change notification settings - Fork 3k
Run snapshot post-layout state steps in resizeObserver loop #11613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This step is necessary for CSS features that depend on post layout state. This includes anchor-positioning, scroll-animations, and scroll-state() container queries. The additional style and layout recalc is for including effects of the updated snapshot.
<ol> | ||
<li><p>Recalculate styles and update layout for <var>doc</var>.</p> | ||
</ol> | ||
</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, but it might be worth at least acknowledging the trade-offs we're making by making it run on every iteration. Also I wonder if we should update content-visibility before or after this...
E.g., what about:
- Update style and layout.
- Do initial content visibility determination and scroll snapshotting.
- If we had an initial determination, or snapshotting changed,
continue
. - ...
Might be a bit easier to reason about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I just ignored the content-visibility part. Would it make sense to also move the viewport proximity to the content-visibility spec and say that it's done when asked to "Run snapshot post-layout state steps"?
Is the continue
part for content-visibility guaranteed to terminate, though? I'm pretty sure it would not be for snapshotting scroll-animations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is, afaict, since you eventually run out of elements that need the initial determination done.
Hmm, it'd be a bit weird that how much a scroll animation advances would depend on whether there are any resize observers or so, I think that means we probably want to do this step only once (maybe at the end so it can react to Resize observers, like the focus fix up?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's done at the end, it would mean resize observers will not see scroll-animations, scroll-state queries, and anchor-positioning taken into account. I don't know what's worst. Doing it once at the start is another option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, indeed. Maybe just do it once on the first iteration of the loop? Any change by a resize observer would be for next frame, which seems fair?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, basically:
- Set didSnapshotPostLayoutState to false
- While true:
- Recalculate styles and update layout for doc
- If didSnapshotPostLayoutState is false
- Run snapshot post-layout state steps for doc.
- Set didSnapshotPostLayoutState to true.
- If any snapshotted state changed:
- continue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's fine. Do we want to merge with the initial c-v determination or so, or move that into the snapshot-post-layout state steps? That does run on every step of the loop r/n...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding @vmpstr to get the input on whether it's intentional/important that the c-v determination runs for every iteration of resize observers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I had imagined that this should run once after at least the first round of resize observers so that animations could use the size set by the resizeobserver in the initially rendered frame.
resize observers will not see scroll-animations, scroll-state queries, and anchor-positioning taken into account
This is really tricky, however I think for the use cases we have now, running after makes more sense.
- scroll driven animations usually care more about observing the output of resize observers and are not likely to change resize observer determining things since that is inefficient to animate.
- scroll-state queries again are usually used for subtle non size affecting things and are more likely to depend on the resize observer output as that may determine whether something is e.g. stuck.
- anchor positioning is the one case where i could see it often being used to determine a size, however given that we already allow for a stale size on the compositor it seems like it wouldn't be too unexpected to have it not update until the next frame.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If running after resizeObservers needs to be done, we can:
- If we run it for all resizeObserver iterations, run it at the same time as content-visibility, and even make content-visibility a "run snapshot post-layout steps".
- If we run it once, we can do one of:
a. run it right after broadcasting resize observations, if it hasn't been run before.
b. run it once when we no longer have active resize observations, and continue if necessary.
Based on a proposal sent as an HTML PR[1]. This CL is based on the iteration in [2]. In short, adding these lines (+) to the resizeObserver loop in HTML: * Let resizeObserverDepth be 0. + * Set didSnapshotPostLayoutState to false * While true: * Recalculate styles and update layout for doc. + * If didSnapshotPostLayoutState is false + * Run snapshot post-layout state steps for doc. + * Set didSnapshotPostLayoutState to true. + * If any snapshotted state changed: + * continue * Let hadInitialVisibleContentVisibilityDetermination be false. [1] whatwg/html#11613 [2] whatwg/html#11613 (comment) Bug: 384523570 Change-Id: Iefd271427ceac8ef260862b469ecfdc52aaafe23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6903971 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1513054}
An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The plan is for the scroll-animations spec to also be expressed in terms of post-layout state snapshotting. The test changes here makes them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. This CL starts with a few edits to check if this is an acceptable approach. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I29c9d7d22c5abf481117857e9463b37413ef5a92
An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The plan is for the scroll-animations spec to also be expressed in terms of post-layout state snapshotting. The test changes here makes them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. This CL starts with a few edits to check if this is an acceptable approach. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I29c9d7d22c5abf481117857e9463b37413ef5a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6947907 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1515714}
An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The plan is for the scroll-animations spec to also be expressed in terms of post-layout state snapshotting. The test changes here makes them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. This CL starts with a few edits to check if this is an acceptable approach. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I29c9d7d22c5abf481117857e9463b37413ef5a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6947907 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1515714}
An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The plan is for the scroll-animations spec to also be expressed in terms of post-layout state snapshotting. The test changes here makes them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. This CL starts with a few edits to check if this is an acceptable approach. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I29c9d7d22c5abf481117857e9463b37413ef5a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6947907 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1515714}
Let a style and layout update happen for a frame before expecting that scroll snapshotting happened. Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: Ie0575420a686903efdae5e88c27e1c593518820c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6954082 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1515992}
Let a style and layout update happen for a frame before expecting that scroll snapshotting happened. Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: Ie0575420a686903efdae5e88c27e1c593518820c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6954082 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1515992}
An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The test changes here makes them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I3332e29c26171815c50fe2a0f16be56fd47276be
An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The test changes here make them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I9435a897fa9fd758ed96bb3c5af373f5b274a463
An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The test changes here make them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I9435a897fa9fd758ed96bb3c5af373f5b274a463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6950416 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1516451}
An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The test changes here makes them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I3332e29c26171815c50fe2a0f16be56fd47276be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6950754 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1516452}
An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The test changes here make them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I9435a897fa9fd758ed96bb3c5af373f5b274a463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6950416 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1516451}
An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The test changes here makes them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I3332e29c26171815c50fe2a0f16be56fd47276be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6950754 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1516452}
An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The test changes here make them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I9435a897fa9fd758ed96bb3c5af373f5b274a463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6950416 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1516451}
An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The test changes here makes them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I3332e29c26171815c50fe2a0f16be56fd47276be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6950754 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1516452}
…y on dirty-tree snapshot, a=testonly Automatic update from web-platform-tests Make some scroll-animation tests not rely on dirty-tree snapshot An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The plan is for the scroll-animations spec to also be expressed in terms of post-layout state snapshotting. The test changes here makes them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. This CL starts with a few edits to check if this is an acceptable approach. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I29c9d7d22c5abf481117857e9463b37413ef5a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6947907 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1515714} -- wpt-commits: dbc92090de5866a72b5d48f979791979f895b177 wpt-pr: 54843
Let a style and layout update happen for a frame before expecting that scroll snapshotting happened. Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: Ie0575420a686903efdae5e88c27e1c593518820c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6954082 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1515992}
…y on dirty-tree snapshot, a=testonly Automatic update from web-platform-tests Make some scroll-timelines tests not rely on dirty-tree snapshot An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The test changes here make them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I9435a897fa9fd758ed96bb3c5af373f5b274a463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6950416 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1516451} -- wpt-commits: 1669f8a6a7ced3cb369bc4eb5db8fe24fd51ced9 wpt-pr: 54883
… on dirty-tree snapshot, a=testonly Automatic update from web-platform-tests Make SVG scroll-animation tests not rely on dirty-tree snapshot An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The test changes here makes them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I3332e29c26171815c50fe2a0f16be56fd47276be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6950754 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1516452} -- wpt-commits: a36a61e5576edd873fd49b14dfec36159538e03d wpt-pr: 54882
Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: I88d37991e8791e276ae7e5632723efd8a82e8d9c
Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: Ic4ba0c31dcf0a1783dd2710462a5061ff8586c52
Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: I4bd0e73da3f90d3eff67043912abfbc23c8547fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6953641 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1519479}
Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: I88d37991e8791e276ae7e5632723efd8a82e8d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6974476 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1519480}
Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: Ic4ba0c31dcf0a1783dd2710462a5061ff8586c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6976604 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1519481}
Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: I88d37991e8791e276ae7e5632723efd8a82e8d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6974476 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1519480}
Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: Ic4ba0c31dcf0a1783dd2710462a5061ff8586c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6976604 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1519481}
Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: I88d37991e8791e276ae7e5632723efd8a82e8d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6974476 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1519480}
Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: Ic4ba0c31dcf0a1783dd2710462a5061ff8586c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6976604 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1519481}
…s for run-snapshot-post-layout, a=testonly Automatic update from web-platform-tests Make anchor-pos scroll snapshot test pass for run-snapshot-post-layout Let a style and layout update happen for a frame before expecting that scroll snapshotting happened. Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: Ie0575420a686903efdae5e88c27e1c593518820c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6954082 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1515992} -- wpt-commits: b3bdac409a7fb2e3ad0d4e0e4d5ba0ba1ee5f635 wpt-pr: 54873
…y on dirty-tree snapshot, a=testonly Automatic update from web-platform-tests Make some scroll-timelines tests not rely on dirty-tree snapshot An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The test changes here make them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I9435a897fa9fd758ed96bb3c5af373f5b274a463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6950416 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1516451} -- wpt-commits: 1669f8a6a7ced3cb369bc4eb5db8fe24fd51ced9 wpt-pr: 54883
… on dirty-tree snapshot, a=testonly Automatic update from web-platform-tests Make SVG scroll-animation tests not rely on dirty-tree snapshot An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The test changes here makes them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I3332e29c26171815c50fe2a0f16be56fd47276be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6950754 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1516452} -- wpt-commits: a36a61e5576edd873fd49b14dfec36159538e03d wpt-pr: 54882
…s for run-snapshot-post-layout, a=testonly Automatic update from web-platform-tests Make anchor-pos scroll snapshot test pass for run-snapshot-post-layout Let a style and layout update happen for a frame before expecting that scroll snapshotting happened. Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: Ie0575420a686903efdae5e88c27e1c593518820c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6954082 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1515992} -- wpt-commits: b3bdac409a7fb2e3ad0d4e0e4d5ba0ba1ee5f635 wpt-pr: 54873
…y on dirty-tree snapshot, a=testonly Automatic update from web-platform-tests Make some scroll-animation tests not rely on dirty-tree snapshot An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The plan is for the scroll-animations spec to also be expressed in terms of post-layout state snapshotting. The test changes here makes them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. This CL starts with a few edits to check if this is an acceptable approach. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I29c9d7d22c5abf481117857e9463b37413ef5a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6947907 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1515714} -- wpt-commits: dbc92090de5866a72b5d48f979791979f895b177 wpt-pr: 54843
…snapshot-post-layout, a=testonly Automatic update from web-platform-tests Make view-timelines/ tests pass for run-snapshot-post-layout Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: I88d37991e8791e276ae7e5632723efd8a82e8d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6974476 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1519480} -- wpt-commits: aeb444897bfb7e8d0976e99f785ad7b9b47d5c41 wpt-pr: 55016
…ss for run-snapshot-post-layout, a=testonly Automatic update from web-platform-tests Make scroll-timelines/setting-* tests pass for run-snapshot-post-layout Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: Ic4ba0c31dcf0a1783dd2710462a5061ff8586c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6976604 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1519481} -- wpt-commits: 538a74ceed6fb26498dccfb6a3ec3aa8baec363a wpt-pr: 55017
Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: I03bb632c6333c11dfe1081825dbea863a718c089
…snapshot-post-layout, a=testonly Automatic update from web-platform-tests Make view-timelines/ tests pass for run-snapshot-post-layout Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: I88d37991e8791e276ae7e5632723efd8a82e8d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6974476 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1519480} -- wpt-commits: aeb444897bfb7e8d0976e99f785ad7b9b47d5c41 wpt-pr: 55016
…ss for run-snapshot-post-layout, a=testonly Automatic update from web-platform-tests Make scroll-timelines/setting-* tests pass for run-snapshot-post-layout Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: Ic4ba0c31dcf0a1783dd2710462a5061ff8586c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6976604 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1519481} -- wpt-commits: 538a74ceed6fb26498dccfb6a3ec3aa8baec363a wpt-pr: 55017
Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: I03bb632c6333c11dfe1081825dbea863a718c089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6975917 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1523396}
Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: I03bb632c6333c11dfe1081825dbea863a718c089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6975917 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1523396}
Preparing for proposed change: whatwg/html#11613 Bug: 384523570 Change-Id: I03bb632c6333c11dfe1081825dbea863a718c089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6975917 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1523396}
This step is necessary for CSS features that depend on post layout state. This includes anchor-positioning, scroll-animations, and scroll-state() container queries.
The additional style and layout recalc is for including effects of the updated snapshot.
(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/webappapis.html ( diff )