Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: add enumerated attribute table for formmethod #10045

Conversation

keithamus
Copy link
Contributor

@keithamus keithamus commented Jan 10, 2024

Per #9832 (comment) I've edited the method/formmethod enumerated attribute table.

I've changed the state names to be capitalized to match the comment @domenic made about inconsistent casing. This is probably one of the more compelling examples in that two of these states are HTTP verbs where the case is implicitly dictated. Thoughts?


/form-control-infrastructure.html ( diff )

@keithamus keithamus force-pushed the editorial-add-enumerated-attribute-table-for-formmethod branch from bf000f4 to 8129a66 Compare January 10, 2024 09:54
@domenic
Copy link
Member

domenic commented Jan 10, 2024

This is probably one of the more compelling examples in that two of these states are HTTP verbs where the case is implicitly dictated. Thoughts?

To me, GET and POST feels slightly better. (Although I'm happy with changing dialog -> Dialog.) The rule is, I guess, "use title case"; if you were going to write about those HTTP verbs in a title, we would keep them all-capitalized.

@annevk
Copy link
Member

annevk commented Jan 10, 2024

I think one I reviewed yesterday was all lowercase. I'm fine either way though.

source Outdated Show resolved Hide resolved
source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@domenic domenic merged commit dcf589e into whatwg:main Jan 31, 2024
2 checks passed
@keithamus keithamus deleted the editorial-add-enumerated-attribute-table-for-formmethod branch January 31, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants