Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear if error event from "update the image data" matches implementations #3839

Open
jdm opened this issue Jul 22, 2018 · 4 comments
Open

Unclear if error event from "update the image data" matches implementations #3839

jdm opened this issue Jul 22, 2018 · 4 comments
Labels
good first issue Ideal for someone new to a WHATWG standard or software project topic: img

Comments

@jdm
Copy link
Member

jdm commented Jul 22, 2018

Attempting to verify the behaviour of step 10 of update the image data, I ran this test in Firefox, Safari, and Chrome on macOS. Each browser only displayed "error1". As far as I can tell img elements with either a srcset attribute or a picture parent should cause the algorithm to be invoked, and then end up with a null selected source. This doesn't appear to match the behaviour of any browser I've tried, however.

cc @zcorpan
@jdm jdm mentioned this issue Jul 22, 2018
Merged
4 tasks
@zcorpan
Copy link
Member

zcorpan commented Aug 13, 2018

So in step 10

⌛ Queue a task to change the current request's current URL to the empty string, and then, if the element has a src attribute or it uses srcset or picture, fire an event named error at the img element.

remove "or it uses srcset or picture", to match what was implemented.

@zcorpan zcorpan added the good first issue Ideal for someone new to a WHATWG standard or software project label Aug 13, 2018
ryzokuken added a commit to ryzokuken/html that referenced this issue Sep 10, 2018
@ryzokuken
Editorial: Update Section 4.8.4.3.5 to match implementation
9f03fde 
Update Step 10 of Section 4.8.4.3.5 (Updating the image data) to match
the implementation. Precisely, removing the text "or it uses srcset or
picture" from the spec (whatwg#3839).
@ryzokuken ryzokuken mentioned this issue Sep 10, 2018
Open
@abinash185
Copy link

I'm working on it. please guide me.

@zcorpan
Copy link
Member

zcorpan commented Feb 2, 2022

@abinash185 maybe someone can help you in the Matrix chat: https://whatwg.org/chat

@Aksshay88

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for someone new to a WHATWG standard or software project topic: img
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jdm @zcorpan @annevk @abinash185 @Aksshay88