Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"abort" Event Isn't Fired When Aborting Document Load #3525

Closed
anthumchris opened this issue Mar 2, 2018 · 6 comments · Fixed by #6720
Closed

"abort" Event Isn't Fired When Aborting Document Load #3525

anthumchris opened this issue Mar 2, 2018 · 6 comments · Fixed by #6720
Labels
removal/deprecation Removing or deprecating a feature topic: document lifecycle topic: events

Comments

@anthumchris
Copy link

anthumchris commented Mar 2, 2018 •
edited
Loading

Is firing an "abort" event still a valid HTML specification?

According to 7.8.12 Aborting a document load, "the user agent should...fire an event named abort at that Document's Window object". I've been testing with this abort event detection page and cannot capture the "abort" event anywhere from any browser.

Detecting the "abort" event in Service Workers would also be extremely useful, as we could effectively manage our Streams, FetchEvents, etc, and react accordingly. For example, this Service Worker Progress Indicator has no way to detect when the user signaled an abort/cancel on the page load. Firefox effectively cancels the download (without firing an "abort" event that SW can intercept, but Chrome does not)
@domenic
Copy link
Member

domenic commented Mar 2, 2018

Edge appears to fire it... although at the HTMLImageElement O_o

@wanderview
Copy link
Member

I think the FetchEvent.request.signal should reflect if the intercepted request is aborted. I don't think we have a WPT test for this yet. We had some bugs in FF around it before, but it may work now or be easier to make work.

@anthumchris
Copy link
Author

Thanks. Filed a Chromium bug:

https://bugs.chromium.org/p/chromium/issues/detail?id=818788

@anthumchris anthumchris mentioned this issue Mar 5, 2018
Closed
@domenic
Copy link
Member

domenic commented Mar 6, 2018

Should we still keep the event in the spec, given that only one browser seems to do it, and that browser does it wrong?

@anthumchris
Copy link
Author

I think the abort event is important and needed because it reflects direct action and intent initiated by users. Users canceling/aborting/stopping page load is also a valid stage in an application's lifecycle. Making this event visible allows for more robust application development and gives options to developers when needed.

The browsers already correctly execute the stop/cancel functionality internally. Browsers would only need to report when that functionality occurs by firing abort.

@anthumchris anthumchris mentioned this issue Mar 9, 2018
Open
@gterzian gterzian mentioned this issue Jun 29, 2018
Closed
@domenic domenic mentioned this issue Jul 9, 2018
Closed
@wbamberg wbamberg mentioned this issue Apr 2, 2019
Closed
11 tasks
@annevk annevk added the removal/deprecation Removing or deprecating a feature label Jan 28, 2021
@annevk
Copy link
Member

annevk commented Jan 28, 2021

We should probably remove this given that no browser implements it.

cc @jakearchibald

domenic added a commit that referenced this issue May 25, 2021
@domenic
Fixes to stopping document loading
e6a167c 
* Makes the discussion of user agent interface invoke "stop document loading", not "abort a document", since the browser stop button also cancels ongoing navigations.

* Remove the "should" suggestion to fire an abort event. Closes #3525. Since this was the only case where abort was fired, this removes the event definition and event handler content attribute definition, effectively making use of the onabort="" content attribute nonconforming. (But, we keep the IDL definition in GlobalEventHandlers and the associated mapping.)

* Tweaks the active document check in "stop document loading" to be more correct.
@domenic domenic mentioned this issue May 25, 2021
Merged
3 tasks
domenic added a commit that referenced this issue May 26, 2021
@domenic
Fixes to stopping document loading
f67b46d 
* Makes the discussion of user agent interface invoke "stop document loading", not "abort a document", since the browser stop button also cancels ongoing navigations.

* Remove the "should" suggestion to fire an abort event. Closes #3525. Since this was the only case where abort was fired, this removes the event definition and event handler content attribute definition, effectively making use of the onabort="" content attribute nonconforming. (But, we keep the IDL definition in GlobalEventHandlers and the associated mapping.)

* Tweaks the active document check in "stop document loading" to be more correct.
This was referenced May 21, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
removal/deprecation Removing or deprecating a feature topic: document lifecycle topic: events
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes to stopping document loading whatwg/html
5 participants
@zcorpan @domenic @wanderview @annevk @anthumchris