Add a render-blocking boolean flag to the request concept #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaochengh
changed the title
xiaochengh
force-pushed
the
render-blocking-behavior
branch
from
2f45e67 to
74c8982
Compare
3 tasks
Contributor
Author
|
@annevk @yoavweiss PTAL |
annevk
reviewed
May 18, 2022
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me modulo some nits.
xiaochengh
commented
May 23, 2022
Contributor
Author
xiaochengh
left a comment
xiaochengh
left a comment
There was a problem hiding this comment.
Thanks for reviewing!
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 24, 2022
This patch follows from the fetch spec revision: whatwg/fetch#1432 Bug: 1271296 Change-Id: I3f56e921e238a7e28774d5407a78d4df4f4145d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3627294 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Patrick Meenan <pmeenan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1007082}
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Jun 1, 2022
See whatwg/fetch#1433 and whatwg/fetch#1432 for background.
mfreed7
pushed a commit
to mfreed7/html
that referenced
this pull request
Jun 3, 2022
See whatwg/fetch#1433 and whatwg/fetch#1432 for background.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1433. The HTML-side counterpart is whatwg/html#7885.
This is also a minor follow-up of whatwg/html#7474.
blocking=renderattribute html#7474blocking=renderattribute html#7474(See WHATWG Working Mode: Changes for more details.)
Preview | Diff