Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augment COEP violation report #1079

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Conversation

yutakahirano
Copy link
Member

@yutakahirano yutakahirano commented Aug 20, 2020

The CORP check now takes "destination" as a parameter.

See also: whatwg/html#5848


Preview | Diff

 - "blocked-url" is renamed to "blockedURL" (whatwg/html#5818).
 - Added "disposition" (whatwg/html#5391).
 - Added "destination" (whatwg/html#5391).

The CORP check now takes "destination" as a parameter.
yutakahirano added a commit to yutakahirano/ServiceWorker that referenced this pull request Aug 20, 2020
whatwg/fetch#1079 added the parameter to
the check. Here we provide the empty string, because request's
destination is not very meaningful here.
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me, modulo nit. Thanks for fixing it so quickly!

fetch.bs Outdated Show resolved Hide resolved
jakearchibald pushed a commit to w3c/ServiceWorker that referenced this pull request Aug 21, 2020
whatwg/fetch#1079 added the parameter to
the check. Here we provide the empty string, because request's
destination is not very meaningful here.
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
@domenic domenic merged commit ad9a84a into master Aug 21, 2020
@domenic domenic deleted the yhirano/coep-report-properties branch August 21, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants