Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bikeshed (remote) returns an error on main branch #1349

Closed
fmarier opened this issue Nov 9, 2021 · 2 comments · Fixed by #1353
Closed

Bikeshed (remote) returns an error on main branch #1349

fmarier opened this issue Nov 9, 2021 · 2 comments · Fixed by #1353

Comments

@fmarier
Copy link

fmarier commented Nov 9, 2021

$ make
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  335k    0   288  100  335k     32  38918  0:00:08  0:00:08 --:--:--    62

Error running preprocessor, returned code: 2.
LINK ERROR: No 'dfn' refs found for 'aborted flag' with for='['AbortSignal']'.
<a data-link-for="AbortSignal" data-link-type="dfn" data-lt="aborted flag">aborted flag</a>
 ✘  Did not generate, due to fatal errors
make: *** [Makefile:5: remote] Error 22

Removing the offending link solves that problem:

--- a/fetch.bs
+++ b/fetch.bs
@@ -7476,7 +7476,7 @@ <h3 id=fetch-method>Fetch method</h3>
  <li><p>Let <var>request</var> be <var>requestObject</var>'s <a for=Request>request</a>.
 
  <li>
-  <p>If <var>requestObject</var>'s <a for=Request>signal</a>'s <a for=AbortSignal>aborted flag</>
+  <p>If <var>requestObject</var>'s <a for=Request>signal</a>'s aborted flag
   is set, then:
 
   <ol>

but perhaps the best fix is to add the missing definition instead.

@fmarier fmarier changed the title Bikeshed returns an error on main branch Bikeshed (remote) returns an error on main branch Nov 9, 2021
@annevk
Copy link
Member

annevk commented Nov 9, 2021

This is due to whatwg/dom@4ca187f. #1343 will sort this out, but I'll create a more short term fix.

annevk added a commit that referenced this issue Nov 9, 2021
Follow-up: integrating abort reason is #1343.

Fixes #1349.
annevk added a commit that referenced this issue Nov 9, 2021
Follow-up: integrating abort reason is #1343.

Fixes #1349.
@annevk
Copy link
Member

annevk commented Nov 9, 2021

Thanks @fmarier!

ericorth pushed a commit to ericorth/fetch that referenced this issue Feb 18, 2022
Follow-up: integrating abort reason is whatwg#1343.

Fixes whatwg#1349.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants