Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace child text content change steps #800

Merged
merged 4 commits into from
Dec 6, 2019
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 5, 2019

It needs to be "children changed steps" as the various consumers appear to react to changes of all sorts.

Tests: web-platform-tests/wpt#15871.

This builds on work started in #732 and will further refine that eventually.


Preview | Diff

It needs to be "children changed steps" as the various consumers appear to react to changes of all sorts.

Tests: web-platform-tests/wpt#15871.

This builds on work started in #732 and will further refine that eventually.
@annevk
Copy link
Member Author

annevk commented Dec 5, 2019

Build is failing due to speced/bikeshed#1558. Edit: #802.

annevk added a commit to whatwg/html that referenced this pull request Dec 5, 2019
As indicated by whatwg/dom#800 and its tests, more than Text node changes are observed by consumers.
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorially LGTM, but the tests only cover style, and need to also cover textarea.

Copy link
Collaborator

@tkent-google tkent-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…nd remove normalize() note as we don't state that elsewhere, e.g., range mutations)
annevk added a commit to web-platform-tests/wpt that referenced this pull request Dec 6, 2019
@annevk annevk merged commit ce4c6ba into master Dec 6, 2019
@annevk annevk deleted the annevk/children-changed branch December 6, 2019 11:21
annevk added a commit to whatwg/html that referenced this pull request Dec 6, 2019
As indicated by whatwg/dom#800 and its tests, more than Text node changes are observed by consumers.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 11, 2019
…only

Automatic update from web-platform-tests
HTML: mutating the style element

For whatwg/dom#800.
--

wpt-commits: 7b63b60158ca7d636aafc099079b2b1b77cdc76a
wpt-pr: 15871
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Dec 12, 2019
…only

Automatic update from web-platform-tests
HTML: mutating the style element

For whatwg/dom#800.
--

wpt-commits: 7b63b60158ca7d636aafc099079b2b1b77cdc76a
wpt-pr: 15871

UltraBlame original commit: e5bae276c12dcdd6e54b0fed97f165f83a274308
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Dec 12, 2019
…only

Automatic update from web-platform-tests
HTML: mutating the style element

For whatwg/dom#800.
--

wpt-commits: 7b63b60158ca7d636aafc099079b2b1b77cdc76a
wpt-pr: 15871

UltraBlame original commit: e5bae276c12dcdd6e54b0fed97f165f83a274308
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Dec 12, 2019
…only

Automatic update from web-platform-tests
HTML: mutating the style element

For whatwg/dom#800.
--

wpt-commits: 7b63b60158ca7d636aafc099079b2b1b77cdc76a
wpt-pr: 15871

UltraBlame original commit: e5bae276c12dcdd6e54b0fed97f165f83a274308
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Dec 16, 2019
…only

Automatic update from web-platform-tests
HTML: mutating the style element

For whatwg/dom#800.
--

wpt-commits: 7b63b60158ca7d636aafc099079b2b1b77cdc76a
wpt-pr: 15871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants