Skip to content

Conversation

@foolip
Copy link
Member

@foolip foolip commented Sep 17, 2015

This makes the output when running bikeshed locally match the current
dom.html output.

This makes the output when running bikeshed locally match the current
dom.html output.
@annevk
Copy link
Member

annevk commented Sep 17, 2015

But I run bikeshed locally too. That's what gets checked in... Is there something else different?

@foolip
Copy link
Member Author

foolip commented Sep 17, 2015

Do you not get any diff other than the changed date? I get this:

--- a/dom.html
+++ b/dom.html
@@ -69,9 +69,11 @@
   <div class="head">
    <p data-fill-with="logo"><a class="logo" href="https://whatwg.org/"> <img alt="WHATWG" height="100" src="https://resources.whatwg.org/logo-dom.svg"> </a> </p>
    <h1 class="p-name no-ref allcaps" id="title">DOM</h1>
-   <h2 class="no-num no-toc no-ref heading settled" id="subtitle"><span class="content">Living Standard — Last Updated <time class="dt-updated" datetime="2015-09-16">16 September 2015</time></span></h2>
+   <h2 class="no-num no-toc no-ref heading settled" id="subtitle"><span class="content">Living Standard — Last Updated <time class="dt-updated" datetime="2015-09-17">17 September 2015</time></span></h2>
    <div data-fill-with="spec-metadata">
     <dl>
+     <dt>Issue Tracking:
+     <dd><a href="/whatwg/dom/issues/">GitHub</a>
      <dt>Participate:
      <dd><span><a href="/whatwg/dom">GitHub whatwg/dom</a> (<a href="/whatwg/dom/issues/new">new issue</a>, <a href="/whatwg/dom/issues">open issues</a>, <a href="https://www.w3.org/Bugs/Public/buglist.cgi?component=DOM&amp;product=WebAppsWG&amp;resolution=---">legacy open bugs</a>)</span>
      <dd><span><a href="https://wiki.whatwg.org/wiki/IRC">IRC: #whatwg on Freenode</a></span>

Bikeshed does some automatic detection of GitHub repos, and I note that it doesn't work if the name of the remote isn't origin, so that seems like the most likely difference in setup.

I did the same fix in w3c/mediasession@d79b445

@annevk
Copy link
Member

annevk commented Sep 17, 2015

I don't get this, no.

@foolip
Copy link
Member Author

foolip commented Sep 17, 2015

What is your output of git remote -v?

@annevk
Copy link
Member

annevk commented Sep 18, 2015

For bikeshed:

origin  https://github.com/tabatkins/bikeshed.git (fetch)
origin  https://github.com/tabatkins/bikeshed.git (push)

For dom:

origin  https://github.com/whatwg/dom.git (fetch)
origin  https://github.com/whatwg/dom.git (push)

@foolip
Copy link
Member Author

foolip commented Sep 18, 2015

My origin is git@github.com:whatwg/dom.git, if you use that you'll see the Issue Track section in the output. I can verify that https://github.com/whatwg/dom.git doesn't cause it to appear.

@tabatkins, is it a bug that only one of these forms is recognized as a GitHub repo?

In any event, I think my change fixes a problem :)

@annevk
Copy link
Member

annevk commented Sep 18, 2015

I cannot fix this at the moment since bikeshed overrides my <dfn>s with stuff from UI Events. This Shepherd setup is somewhat frustrating.

@foolip
Copy link
Member Author

foolip commented Sep 18, 2015

Yeah, I'm seeing the same thing after updating. Annoying, and I guess the dependencies aren't tracked by Git so you can't roll back while it's being fixed. Have you filed a bug somewhere?

@annevk
Copy link
Member

annevk commented Sep 18, 2015

The way to file a bug is to bug either @tabatkins or @plinss. I guess now I've bugged both.

@tabatkins
Copy link
Contributor

Yeah, dealing with it now. Sorry, I was sick most of last week in a way that made me only want to play videogames on the couch. >_<

@tabatkins
Copy link
Contributor

Okay, fuck it, for now I've just made all non-partial interfaces automatically become <dfn>s. This will change in the near future, when I add proper support for marking obsoletion of definitions, so watch for that. Follow speced/bikeshed#321 for notifications of known breaking changes.

@tabatkins
Copy link
Contributor

@foolip: Oh, and it is a Bikeshed bug that https origins aren't recognized by Bikeshed; it only knows about SSH urls. I'll file a bug on myself and fix at some point.

@annevk annevk closed this Sep 22, 2015
@foolip foolip deleted the omit-feedback-header branch September 22, 2015 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants