-
Notifications
You must be signed in to change notification settings - Fork 320
Use Boilerplate: omit feedback-header to remove redundant GitHub link #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This makes the output when running bikeshed locally match the current dom.html output.
|
But I run bikeshed locally too. That's what gets checked in... Is there something else different? |
|
Do you not get any diff other than the changed date? I get this: --- a/dom.html
+++ b/dom.html
@@ -69,9 +69,11 @@
<div class="head">
<p data-fill-with="logo"><a class="logo" href="https://whatwg.org/"> <img alt="WHATWG" height="100" src="https://resources.whatwg.org/logo-dom.svg"> </a> </p>
<h1 class="p-name no-ref allcaps" id="title">DOM</h1>
- <h2 class="no-num no-toc no-ref heading settled" id="subtitle"><span class="content">Living Standard — Last Updated <time class="dt-updated" datetime="2015-09-16">16 September 2015</time></span></h2>
+ <h2 class="no-num no-toc no-ref heading settled" id="subtitle"><span class="content">Living Standard — Last Updated <time class="dt-updated" datetime="2015-09-17">17 September 2015</time></span></h2>
<div data-fill-with="spec-metadata">
<dl>
+ <dt>Issue Tracking:
+ <dd><a href="/whatwg/dom/issues/">GitHub</a>
<dt>Participate:
<dd><span><a href="/whatwg/dom">GitHub whatwg/dom</a> (<a href="/whatwg/dom/issues/new">new issue</a>, <a href="/whatwg/dom/issues">open issues</a>, <a href="https://www.w3.org/Bugs/Public/buglist.cgi?component=DOM&product=WebAppsWG&resolution=---">legacy open bugs</a>)</span>
<dd><span><a href="https://wiki.whatwg.org/wiki/IRC">IRC: #whatwg on Freenode</a></span>Bikeshed does some automatic detection of GitHub repos, and I note that it doesn't work if the name of the remote isn't origin, so that seems like the most likely difference in setup. I did the same fix in w3c/mediasession@d79b445 |
|
I don't get this, no. |
|
What is your output of |
|
For bikeshed: For dom: |
|
My origin is @tabatkins, is it a bug that only one of these forms is recognized as a GitHub repo? In any event, I think my change fixes a problem :) |
|
I cannot fix this at the moment since bikeshed overrides my |
|
Yeah, I'm seeing the same thing after updating. Annoying, and I guess the dependencies aren't tracked by Git so you can't roll back while it's being fixed. Have you filed a bug somewhere? |
|
The way to file a bug is to bug either @tabatkins or @plinss. I guess now I've bugged both. |
|
Yeah, dealing with it now. Sorry, I was sick most of last week in a way that made me only want to play videogames on the couch. >_< |
|
Okay, fuck it, for now I've just made all non-partial interfaces automatically become |
|
@foolip: Oh, and it is a Bikeshed bug that https origins aren't recognized by Bikeshed; it only knows about SSH urls. I'll file a bug on myself and fix at some point. |
This makes the output when running bikeshed locally match the current
dom.html output.