Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the adopting steps recursively #66

Closed
wants to merge 2 commits into from

Conversation

nox
Copy link
Member

@nox nox commented Sep 3, 2015

When adopting a 's template contents and running its own adopting steps as defined in HTML, if the adopting steps aren't recursively, any nested template won't see its template contents' owner document changed.

@nox
Copy link
Member Author

nox commented Sep 3, 2015

No idea what that AttrExodus comment is about.


<ol>
<li>Set <var>descendant</var>'s <a>node document</a> to <var>document</var>.
<!--AttrExodus as well as any associated {{Attr}} nodes-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be followed by a newline.

@annevk
Copy link
Member

annevk commented Sep 3, 2015

AttrExodus is for when we find out we need to revive the concept of Attr as a Node.

When adopting a <template>'s template contents and running its own adopting steps
as defined in HTML, if the adopting steps aren't recursively, any nested template
won't see its template contents' owner document changed.
@nox
Copy link
Member Author

nox commented Sep 3, 2015

Added the new line.

@annevk annevk closed this in 5697cf4 Sep 5, 2015
nox added a commit to nox/dom that referenced this pull request Sep 7, 2015
@Ms2ger pointed out to me that the fix introduced in whatwg#66 is less than perfect,
because the unsuspecting loop over node's inclusive descendants mean running
their adopting steps in a tree of which nodes are owned by two different
documents.
nox added a commit to nox/dom that referenced this pull request Sep 7, 2015
@Ms2ger pointed out to me that the fix introduced in whatwg#66 is less than perfect,
because the unsuspecting loop over node's inclusive descendants mean running
their adopting steps in a tree of which nodes are owned by two different
documents.
@nox nox mentioned this pull request Sep 7, 2015
@nox nox deleted the recursive-adopting-steps branch October 22, 2015 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants