Define event constructing steps #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hook can be used by complex Event subclasses, such as KeyboardEvent and TouchEvent, to initialize their internal state upon creation. Fixes #414.
|
@garykac your input on this would be much appreciated as well, as this'll primarily affect UI events I think. |
hayatoito
approved these changes
Mar 26, 2018
annevk
added a commit
that referenced
this pull request
Mar 27, 2018
annevk
added a commit
that referenced
this pull request
Mar 27, 2018
annevk
added a commit
that referenced
this pull request
Mar 28, 2018
This makes a number of large changes to event dispatch: * The algorithm can no longer return early with true. The observable aspect is that the event object is "uninitialized" and false might be returned if the event object was already canceled. * It accounts for Touch Events in shadow trees by adding the "touch target list" which is somewhat similar to relatedTarget. * Retargeting for event targets is now solely controlled by the event dispatch algorithm. The hook for other specifications is removed. * Retargeting now properly accounts for non-node objects. * Dispatch in general accounts for non-node objects too now. * If targets need to be unset to prevent exposure of a shadow tree this is now calculated prior to invoking listeners. Initializing relatedTarget and "touch target list" is up to the event classes that need it. #614 will add "event constructing steps" that enable this. Tests: web-platform-tests/wpt#9919 (probably still needs work given today's changes) This closes #402, fixes #561, fixes #562, fixes #580, and fixes #602.
This was referenced Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook can be used by complex Event subclasses, such as KeyboardEvent and TouchEvent, to initialize their internal state upon creation.
Fixes #414.
Preview | Diff