Move promise resolved flag checking/setting. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the checking and subsequent setting of the resolved flag from `fulfill`, `reject`, and `resolve` to the internal fulfill, reject, and resolve algorithms. This is more resilient in the face of malicious thenables, which as currently specified can cause multiple fulfillment, multiple rejection, or any combination thereof. Fixes http://lists.w3.org/Archives/Public/www-dom/2013AprJun/0283.html
Member
Author
|
I had no idea how to run that Makefile or generate a dom-core.html, FWIW. A readme or CONTRIBUTING.md might be helpful in that regard. |
Member
|
You did not read the Makefile? The first line points out how to make it work. |
Member
|
Also, this patch is wrong. How can internal resolve now invoke internal accept or reject without the flag being set? |
Member
Author
|
How embarrassing on both counts. Will try again tonight-ish. In my defense, I usually skip over the first line of a file if it starts with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the checking and subsequent setting of the resolved flag from
fulfill,reject, andresolveto the internal fulfill, reject, and resolve algorithms. This is more resilient in the face of malicious thenables, which as currently specified can cause multiple fulfillment, multiple rejection, or any combination thereof.Fixes http://lists.w3.org/Archives/Public/www-dom/2013AprJun/0283.html