Fix queuing of mutation records when removing a node from its parent #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old next sibling of the node needs to be stored somewhere before removing the node from its parent.
|
Can we use oldPreviousSibling's next sibling? |
|
@annevk That makes things more complex. There could be no oldPreviousSibling, in which case we would need the parent's first child. |
|
Thank you! |
nox
added a commit
to nox/dom
that referenced
this pull request
Nov 30, 2015
A node's next sibling needs to be stored before removing the node from its parent.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old next sibling of the node needs to be stored somewhere before removing
the node from its parent.