Skip to content

Correct MutationObserver ownership story #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Correct MutationObserver ownership story #1160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee77836
Correct MutationObserver ownership story
annevk Feb 13, 2023
5d7c322
nits
annevk Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 18 additions & 26 deletions dom.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3363,7 +3363,7 @@ must return null.
(a boolean), which is initially false. [[!HTML]]

<p>Each <a>similar-origin window agent</a> also has
<dfn noexport id=mutation-observer-list>mutation observers</dfn> (a <a for=/>set</a> of zero or more
<dfn id=mutation-observer-list>pending mutation observers</dfn> (a <a for=/>set</a> of zero or more
{{MutationObserver}} objects), which is initially empty.

<p>To
Expand All @@ -3385,7 +3385,9 @@ run these steps:
<li><p>Set the <a>surrounding agent</a>'s <a>mutation observer microtask queued</a> to false.

<li><p>Let <var>notifySet</var> be a <a for=set>clone</a> of the <a>surrounding agent</a>'s
<a>mutation observers</a>.
<a>pending mutation observers</a>.

<li><p><a for=set>Empty</a> the <a>surrounding agent</a>'s <a>pending mutation observers</a>.

<li><p>Let <var>signalSet</var> be a <a for=set>clone</a> of the <a>surrounding agent</a>'s
<a>signal slots</a>.
Expand Down Expand Up @@ -3465,12 +3467,12 @@ dictionary MutationObserverInit {

<p>Each {{MutationObserver}} object has these associated concepts:

<ul>
<li>A <dfn noexport for=MutationObserver id=concept-mo-callback>callback</dfn> set on creation.
<li>A <dfn noexport for=MutationObserver>node list</dfn> (a <a for=/>list</a> of
<ul class=brief>
<li>A <dfn for=MutationObserver id=concept-mo-callback>callback</dfn> set on creation.
<li>A <dfn for=MutationObserver>node list</dfn> (a <a for=/>list</a> of weak references to
<a for=/>nodes</a>), which is initially empty.
<li>A <dfn export for=MutationObserver id=concept-mo-queue>record queue</dfn> (a <a for=/>queue</a>
of zero or more {{MutationRecord}} objects), which is initially empty.
<li>A <dfn for=MutationObserver id=concept-mo-queue>record queue</dfn> (a <a for=/>queue</a> of
zero or more {{MutationRecord}} objects), which is initially empty.
</ul>

<dl class=domintro>
Expand Down Expand Up @@ -3548,14 +3550,8 @@ dictionary MutationObserverInit {

<p>The
<dfn constructor for=MutationObserver lt=MutationObserver(callback)><code>new MutationObserver(<var>callback</var>)</code></dfn>
constructor steps are:

<ol>
<li><p>Set <a>this</a>'s <a for=MutationObserver>callback</a> to <var>callback</var>.

<li><p><a for=set>Append</a> <a>this</a> to <a>this</a>'s <a>relevant agent</a>'s
<a>mutation observers</a>.
</ol>
constructor steps are to set <a>this</a>'s <a for=MutationObserver>callback</a> to
<var>callback</var>.

<p>The
<dfn method for=MutationObserver><code>observe(<var>target</var>, <var>options</var>)</code></dfn>
Expand Down Expand Up @@ -3613,7 +3609,7 @@ method steps are:
<a for="registered observer">options</a> is <var>options</var> to <var>target</var>'s
<a>registered observer list</a>.

<li><p><a for=list>Append</a> <var>target</var> to <a>this</a>'s
<li><p><a for=list>Append</a> a weak reference to <var>target</var> to <a>this</a>'s
<a for=MutationObserver>node list</a>.
</ol>
</ol>
Expand Down Expand Up @@ -3716,6 +3712,9 @@ method steps are:

<li><p><a for=queue>Enqueue</a> <var>record</var> to <var>observer</var>'s
<a for=MutationObserver>record queue</a>.

<li><p><a for=set>Append</a> <var>observer</var> to the <a>surrounding agent</a>'s
<a>pending mutation observers</a>.
</ol>

<li><p><a>Queue a mutation observer microtask</a>.
Expand Down Expand Up @@ -3811,15 +3810,6 @@ interface MutationRecord {
initialized to.


<h4 id=garbage-collection>Garbage collection</h4>

<p><a for=/>Nodes</a> have a strong reference to <a>registered observers</a> in their
<a>registered observer list</a>.

<p><a>Registered observers</a> in a <a for=/>node</a>'s <a>registered observer list</a> have a weak
reference to the <a for=/>node</a>.


<h3 id=interface-node>Interface {{Node}}</h3>

<pre class=idl>
Expand Down Expand Up @@ -10073,6 +10063,7 @@ Elliott Sprehn,
Emilio Cobos Álvarez,
Eric Bidelman,
Erik Arvidsson,
François Remy<!-- FremyCompany; GitHub -->,
Gary Kacmarcik,
Gavin Nicol,
Giorgio Liscio,
Expand Down Expand Up @@ -10165,6 +10156,7 @@ Sam Dutton,
Sam Sneddon,
Samuel Giles,
Sanket Joshi,
Scott Haseley<!-- shaseley; GitHub -->,
Sebastian Mayr,
Seo Sanghyeon,
Sergey G. Grekhov,
Expand All @@ -10185,7 +10177,7 @@ Tobie Langel,
Tom Pixley,
Travis Leithead,
Trevor Rowbotham,
<i>triple-underscore</i>,<!--GitHub-->
<i>triple-underscore</i><!--GitHub-->,
Tristan Fraipont,
Veli Şenol,
Vidur Apparao,
Expand Down