Introduce abortSignal.throwIfAborted() #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
Nov 24, 2021
jasnell
approved these changes
Nov 24, 2021
jasnell
added a commit
to jasnell/node
that referenced
this pull request
Nov 24, 2021
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <jasnell@gmail.com>
|
Awesome :). If we can take Mozilla as interested per @annevk's enthusiasm, then this is ready to merge as soon as someone writes tests. |
annevk
added
the
needs tests
jasnell
added a commit
to jasnell/node
that referenced
this pull request
Dec 2, 2021
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <jasnell@gmail.com>
annevk
force-pushed
the
abortsignal-throwifaborted
branch
from
d001912
to
0645ef6
Compare
|
@domenic .. WPT test PR here: web-platform-tests/wpt#31947 |
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 8, 2021
domenic
removed
the
needs tests
|
Tests are merged; merge at will @annevk! |
andreubotella
pushed a commit
to andreubotella/deno
that referenced
this pull request
Dec 10, 2021
andreubotella
pushed a commit
to andreubotella/deno
that referenced
this pull request
Dec 10, 2021
lucacasonato
pushed a commit
to denoland/deno
that referenced
this pull request
Dec 10, 2021
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Dec 10, 2021
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #40951 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
Should probably be added to web-platform-tests/interfaces/dom.idl too. |
|
@cdumez that should happen automatically through a bot, but it might take a day or so. |
|
PR landed in node.js! support will roll out in the next 17.x release |
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 14, 2021
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #40951 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 20, 2021
… a=testonly Automatic update from web-platform-tests Tests for abortSignal.throwIfAborted() Follows whatwg/dom#1034. -- wpt-commits: b03df354b93b285fe1764d567b7c1a074df4a808 wpt-pr: 31947
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#40951 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Aug 1, 2022
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #40951 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Aug 1, 2022
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #40951 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs/node#40951 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #927.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff