Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign slotables for a tree should be invoked on node and not node's root in node remove #691

Closed
pmdartus opened this issue Sep 9, 2018 · 1 comment
Closed

Assign slotables for a tree should be invoked on node and not node's root in node remove #691

pmdartus opened this issue Sep 9, 2018 · 1 comment
Labels
clarification Standard could be clearer topic: shadow Relates to shadow trees (as defined in DOM)

Comments

@pmdartus
Copy link
Member

pmdartus commented Sep 9, 2018

https://dom.spec.whatwg.org/commit-snapshots/28cdb47e557c814fcca60759f4cce43e9c0e9a47/#concept-node-remove

12.2. Run assign slotables for a tree with node’s root.

In the remove node algorithm, the root of the node at this point (12.2.) is always the node itself since it has already been detached from the tree (9.). It should run assign slotable for a tree on the node and not the node's root.

See: jsdom/jsdom#2347 (comment)
@pmdartus pmdartus mentioned this issue Sep 9, 2018
Merged
@annevk annevk added the topic: shadow Relates to shadow trees (as defined in DOM) label Sep 10, 2018
annevk added a commit that referenced this issue Sep 10, 2018
@annevk
Editorial: a removed node's root is itself
b6ef1d5 
Fixes #691.
@annevk annevk mentioned this issue Sep 10, 2018
Merged
@annevk
Copy link
Member

annevk commented Sep 10, 2018

Created a PR for this as on reflection this is simply an editorial change.

@annevk annevk added the clarification Standard could be clearer label Sep 10, 2018
annevk added a commit that referenced this issue Sep 11, 2018
@annevk
Editorial: a removed node's root is itself
42d2485 
Also address some issues Bikeshed found (incorrect linking and the use of "optional" in a non-normative context).

Fixes #691.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer topic: shadow Relates to shadow trees (as defined in DOM)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@annevk @pmdartus