Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fix for replace algo and question #129

Closed
ArkadiuszMichalski opened this issue Dec 16, 2015 · 1 comment
Closed

Some fix for replace algo and question #129

ArkadiuszMichalski opened this issue Dec 16, 2015 · 1 comment

Comments

@ArkadiuszMichalski
Copy link
Contributor

https://dom.spec.whatwg.org/#concept-node-replace
12. If child’s parent is not null, set removedNodes to a list solely containing child and remove child from its parent with the suppress observers flag set. << first "parent" and "remove" should not be linked? Especially for "remove" because I don't know if you mean "remove algo" or direct term.

And have another question, why in step 13. we again remove child from its parent? We have it in step 12, or, if child is same as node, then removing from parent is done in step 10. via "adopt algo" (https://dom.spec.whatwg.org/#concept-node-adopt).

@nox
Copy link
Member

nox commented Dec 16, 2015

@ArkadiuszMichalski @annevk Some very bad amending shenanigans happened when I did the initial patch, will fix that tonight.

nox added a commit to nox/dom that referenced this issue Dec 16, 2015
nox added a commit to nox/dom that referenced this issue Dec 16, 2015
@annevk annevk closed this as completed in cfaf3fa Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants