Change use darkColorScheme default in customJson is null #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuocNguyen-w3w
approved these changes
Feb 18, 2025
mani-apps
requested changes
Feb 18, 2025
| val googleMapOptions = remember(state.isDarkMode) { | ||
| GoogleMapOptions() | ||
| .mapColorScheme( | ||
| if (state.isDarkMode) MapColorScheme.LIGHT else MapColorScheme.DARK |
There was a problem hiding this comment.
@kaytran2992 here says that if state isDarkMode use MapColorScheme.LIGHT, is this the expected? the naming is just slightly contradictory and can get confusing
There was a problem hiding this comment.
The GG Map has an issue with googleMapOptions, which reproduces this issue somehow: https://issuetracker.google.com/issues/351858982 that makes me missunderstanding it. But seems to work by using mapColorScheme: ComposeMapColorScheme. = null.
kaytran2992
force-pushed
the
fix/Apply-GGMap-darkColorScheme-default
branch
from
91be16f to
3203f35
Compare
🦞 Coverage Report
|
kaytran2992
merged commit 5b2f1dd
into
epic/MT-6865-Create-a-new-UI-for-Map-component
2 checks passed
kaytran2992
added a commit
that referenced
this pull request
Mar 5, 2025
…me-default Change use darkColorScheme default in customJson is null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.