This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Add line-delimited streaming support to crypto-client #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #907.
In order to process data as it comes in, it would be useful to have streaming support for GET requests.
Add streaming support for GET requests, and add a lib to emit data line by line.
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
Codecov Report
@@ Coverage Diff @@
## master #908 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 2 2
Lines 153 153
=======================================
Hits 146 146
Misses 7 7Continue to review full report at Codecov.
|
johnsonw
approved these changes
May 2, 2019
utopiabound
approved these changes
May 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #907.
In order to process data as it comes in, it would be useful to have streaming support for GET requests.
Add streaming support for GET requests, and add a lib to emit data line by line.
Signed-off-by: Joe Grund jgrund@whamcloud.io