Skip to content

Add additional logging for env file sourcing in GH Action builds #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnKallies merged 3 commits into from
Oct 3, 2023
Merged

Add additional logging for env file sourcing in GH Action builds #457

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8412680
Add additional logging for env file sourcing in GH Action builds
JohnKallies Oct 2, 2023
1b66fb7
add more consistent log messages
JohnKallies Oct 3, 2023
97204aa
add clarity to loggin messages
JohnKallies Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions bin/lib/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ source_env_file() {
source_env_file_unless_provided_oauth() {
local env_file="${1}"

# gracefully bypass sourcing env file if these 4 OAUTH values are provided
# gracefully bypass sourcing env file if these 4 OAUTH_ values are provided, i.e. as secrets
# via build automation
if [[ \
-n "${OAUTH_ISSUER}" && \
-n "${OAUTH_CLIENTID}" && \
Expand All @@ -63,22 +64,25 @@ source_env_file_unless_provided_oauth() {
return 0
fi

echo_info "OAUTH_ values are not provided by environment variables. Sourcing ${env_file} env file."
source_env_file "${env_file}"
}

source_env_file_unless_provided_okta() {
local env_file="${1}"

# gracefully bypass sourcing env file if these 4 OAUTH values are provided
# gracefully bypass sourcing env file if these 3 OKTA_ values are provided, i.e. as secrets
# via build automation
if [[ \
-n "${OKTA_URL}" && \
-n "${OKTA_USERNAME}" && \
-n "${OKTA_PASSWORD}" \
]]; then
echo_info "Okta values are provided by environment variables. Not sourcing ${env_file} env file."
echo_info "OKTA_ values are provided by environment variables. Not sourcing ${env_file} env file."
return 0
fi

echo_info "Okta values are not provided by environment variables. Sourcing ${env_file} env file."
source_env_file "${env_file}"
}

Expand Down