DMND-1779 Utilizing application.properties to set the new Easticsearc… #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h RestClient in ElasticsearchClientManager.kt
shnooga
requested review from
JohnKallies,
campeterson22,
jesusgudino and
stirhale-wgu
JohnKallies
reviewed
Sep 29, 2023
|
|
||
| spring.flyway.enabled=true | ||
|
|
||
| es.username= |
Contributor
There was a problem hiding this comment.
This should not be in the dev properties file for open source work. Please put it in application.properties.
Also, the local Docker stack will need with a preconfigured username and password. Trace through using ELASTICSEARCH_URI, and follow this pattern.
added 8 commits
September 29, 2023 16:19
…template to ignore the filter property; fixed for FindsAllByPublishStatus but needs to update the more complex CollectionEsRepo and RichSkilsEsRepo.
…precated typeAheadSearch() as sample code for upgrading to ElasticSearch v8.7.X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leveraging application.properties to set ElasticSearch RestClient in ElasticsearchClientManager.kt