Search and Delete Job Codes #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuel-delvillar
force-pushed
the
feature/OSMT-280-search-job-codes
branch
2 times, most recently
from
7cddc2a to
3d99156
Compare
manuel-delvillar
changed the title
schagantiwgu
suggested changes
Jun 9, 2023
Contributor
There was a problem hiding this comment.
User functionality changes
While deleting multiple job codes at the same time as there is an option at the bottom of the page "delete selected" the "delete" option on single record/checkbox on single record needs to be disabled.
Having a single record delete option is deleting only a single record even when multiple are selected and the "select all" box doesn't clear but each of the single selects gets cleared.
After that the "delete selected" option is still visible to the user and when clicked deletes all the records.
Note: If more than one record is selected, enable "delete selected" option else disable that and keep "delete" option on single record enabled.
Screenshots demonstrating the UI experience
JohnKallies
reviewed
Jun 9, 2023
JohnKallies
reviewed
Jun 9, 2023
ui/src/app/metadata/detail/metadata-list/metadata-list.component.ts
Outdated
Show resolved
Hide resolved
manuel-delvillar
force-pushed
the
feature/OSMT-280-search-job-codes
branch
from
04c0130 to
0cb85d8
Compare
schagantiwgu
suggested changes
Jun 9, 2023
Contributor
There was a problem hiding this comment.
- Empty pop up showing while "delete" option is disabled. Instead disable the click on three dots.
- "Select all" checkbox needs to reset when:
- All records are deleted
- All records are not selected
- Select all resets if data in table has changed or for new search.
manuel-delvillar
force-pushed
the
feature/OSMT-280-search-job-codes
branch
from
42f3de9 to
39f0839
Compare
manuel-delvillar
force-pushed
the
feature/admin-screens
branch
from
9f4aea8 to
9cd2094
Compare
- Add EnableGlobalMethodSecurity annotation in SecurityConfig
- Add id in ApiJobCode (ui & api) - Call request to delete in ui
- Matching query is updated until we search, not while we type. - If select all is selected and unselect one job code, select all is unchecked. - Disable dots menu if is without actions.
manuel-delvillar
force-pushed
the
feature/OSMT-280-search-job-codes
branch
from
39f0839 to
71c55ff
Compare
schagantiwgu
approved these changes
Jun 20, 2023
4 tasks
manuel-delvillar
added a commit
that referenced
this pull request
Jun 28, 2023
* Working with pagination * Add sort insensitive * Add job code level and parents * Delete job code * Fix delete test * Remove PaginatedJobCodes * Show job codes in list * Request all on clear search * Delete job code by id - Add id in ApiJobCode (ui & api) - Call request to delete in ui * Show toast when job code is deleted * Add confirm message & reload on delete * Fix broken tests * Update open API * Update table job codes - Sort by code - Remove framework name column * Show parents - Add pipe to show parents * Sort by job code level * Add validation to delete a job code - You cannot delete a jobcode with RSDs - You cannot delete a job code with children * Fix create from api * Add error messages on delete job code * Add test new functions back end * Update texts * Update values for MetadataType * Add new tests * Fix broken tests * Remove unused import * Add id property for job code in open api - Requests are without id and responses are with id. * Delete multiple job codes * Improve notifications on delete * Add back to top * Add abstract list * Fix text on action * Clean selected data after delete one or more job codes * Fix table * Disable delete single if select all is checked * Add property to job code in open api - Matching query is updated until we search, not while we type. - If select all is selected and unselect one job code, select all is unchecked. - Disable dots menu if is without actions. * Uncheck select all if items change * Check all selected if all are selected
8 tasks
manuel-delvillar
added a commit
that referenced
this pull request
Jul 7, 2023
* Working with pagination * Add sort insensitive * Add job code level and parents * Delete job code * Fix delete test * Remove PaginatedJobCodes * Show job codes in list * Request all on clear search * Delete job code by id - Add id in ApiJobCode (ui & api) - Call request to delete in ui * Show toast when job code is deleted * Add confirm message & reload on delete * Fix broken tests * Update open API * Update table job codes - Sort by code - Remove framework name column * Show parents - Add pipe to show parents * Sort by job code level * Add validation to delete a job code - You cannot delete a jobcode with RSDs - You cannot delete a job code with children * Fix create from api * Add error messages on delete job code * Add test new functions back end * Update texts * Update values for MetadataType * Add new tests * Fix broken tests * Remove unused import * Add id property for job code in open api - Requests are without id and responses are with id. * Delete multiple job codes * Improve notifications on delete * Add back to top * Add abstract list * Fix text on action * Clean selected data after delete one or more job codes * Fix table * Disable delete single if select all is checked * Add property to job code in open api - Matching query is updated until we search, not while we type. - If select all is selected and unselect one job code, select all is unchecked. - Disable dots menu if is without actions. * Uncheck select all if items change * Check all selected if all are selected
manuel-delvillar
added a commit
that referenced
this pull request
Jul 11, 2023
* Working with pagination * Add sort insensitive * Add job code level and parents * Delete job code * Fix delete test * Remove PaginatedJobCodes * Show job codes in list * Request all on clear search * Delete job code by id - Add id in ApiJobCode (ui & api) - Call request to delete in ui * Show toast when job code is deleted * Add confirm message & reload on delete * Fix broken tests * Update open API * Update table job codes - Sort by code - Remove framework name column * Show parents - Add pipe to show parents * Sort by job code level * Add validation to delete a job code - You cannot delete a jobcode with RSDs - You cannot delete a job code with children * Fix create from api * Add error messages on delete job code * Add test new functions back end * Update texts * Update values for MetadataType * Add new tests * Fix broken tests * Remove unused import * Add id property for job code in open api - Requests are without id and responses are with id. * Delete multiple job codes * Improve notifications on delete * Add back to top * Add abstract list * Fix text on action * Clean selected data after delete one or more job codes * Fix table * Disable delete single if select all is checked * Add property to job code in open api - Matching query is updated until we search, not while we type. - If select all is selected and unselect one job code, select all is unchecked. - Disable dots menu if is without actions. * Uncheck select all if items change * Check all selected if all are selected
manuel-delvillar
added a commit
that referenced
this pull request
Jul 11, 2023
* Working with pagination * Add sort insensitive * Add job code level and parents * Delete job code * Fix delete test * Remove PaginatedJobCodes * Show job codes in list * Request all on clear search * Delete job code by id - Add id in ApiJobCode (ui & api) - Call request to delete in ui * Show toast when job code is deleted * Add confirm message & reload on delete * Fix broken tests * Update open API * Update table job codes - Sort by code - Remove framework name column * Show parents - Add pipe to show parents * Sort by job code level * Add validation to delete a job code - You cannot delete a jobcode with RSDs - You cannot delete a job code with children * Fix create from api * Add error messages on delete job code * Add test new functions back end * Update texts * Update values for MetadataType * Add new tests * Fix broken tests * Remove unused import * Add id property for job code in open api - Requests are without id and responses are with id. * Delete multiple job codes * Improve notifications on delete * Add back to top * Add abstract list * Fix text on action * Clean selected data after delete one or more job codes * Fix table * Disable delete single if select all is checked * Add property to job code in open api - Matching query is updated until we search, not while we type. - If select all is selected and unselect one job code, select all is unchecked. - Disable dots menu if is without actions. * Uncheck select all if items change * Check all selected if all are selected
Corpratespaz
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Working with pagination * Add sort insensitive * Add job code level and parents * Delete job code * Fix delete test * Remove PaginatedJobCodes * Show job codes in list * Request all on clear search * Delete job code by id - Add id in ApiJobCode (ui & api) - Call request to delete in ui * Show toast when job code is deleted * Add confirm message & reload on delete * Fix broken tests * Update open API * Update table job codes - Sort by code - Remove framework name column * Show parents - Add pipe to show parents * Sort by job code level * Add validation to delete a job code - You cannot delete a jobcode with RSDs - You cannot delete a job code with children * Fix create from api * Add error messages on delete job code * Add test new functions back end * Update texts * Update values for MetadataType * Add new tests * Fix broken tests * Remove unused import * Add id property for job code in open api - Requests are without id and responses are with id. * Delete multiple job codes * Improve notifications on delete * Add back to top * Add abstract list * Fix text on action * Clean selected data after delete one or more job codes * Fix table * Disable delete single if select all is checked * Add property to job code in open api - Matching query is updated until we search, not while we type. - If select all is selected and unselect one job code, select all is unchecked. - Disable dots menu if is without actions. * Uncheck select all if items change * Check all selected if all are selected
manuel-delvillar
added a commit
that referenced
this pull request
Jul 18, 2023
* Working with pagination * Add sort insensitive * Add job code level and parents * Delete job code * Fix delete test * Remove PaginatedJobCodes * Show job codes in list * Request all on clear search * Delete job code by id - Add id in ApiJobCode (ui & api) - Call request to delete in ui * Show toast when job code is deleted * Add confirm message & reload on delete * Fix broken tests * Update open API * Update table job codes - Sort by code - Remove framework name column * Show parents - Add pipe to show parents * Sort by job code level * Add validation to delete a job code - You cannot delete a jobcode with RSDs - You cannot delete a job code with children * Fix create from api * Add error messages on delete job code * Add test new functions back end * Update texts * Update values for MetadataType * Add new tests * Fix broken tests * Remove unused import * Add id property for job code in open api - Requests are without id and responses are with id. * Delete multiple job codes * Improve notifications on delete * Add back to top * Add abstract list * Fix text on action * Clean selected data after delete one or more job codes * Fix table * Disable delete single if select all is checked * Add property to job code in open api - Matching query is updated until we search, not while we type. - If select all is selected and unselect one job code, select all is unchecked. - Disable dots menu if is without actions. * Uncheck select all if items change * Check all selected if all are selected
manuel-delvillar
added a commit
that referenced
this pull request
Jul 19, 2023
* Working with pagination * Add sort insensitive * Add job code level and parents * Delete job code * Fix delete test * Remove PaginatedJobCodes * Show job codes in list * Request all on clear search * Delete job code by id - Add id in ApiJobCode (ui & api) - Call request to delete in ui * Show toast when job code is deleted * Add confirm message & reload on delete * Fix broken tests * Update open API * Update table job codes - Sort by code - Remove framework name column * Show parents - Add pipe to show parents * Sort by job code level * Add validation to delete a job code - You cannot delete a jobcode with RSDs - You cannot delete a job code with children * Fix create from api * Add error messages on delete job code * Add test new functions back end * Update texts * Update values for MetadataType * Add new tests * Fix broken tests * Remove unused import * Add id property for job code in open api - Requests are without id and responses are with id. * Delete multiple job codes * Improve notifications on delete * Add back to top * Add abstract list * Fix text on action * Clean selected data after delete one or more job codes * Fix table * Disable delete single if select all is checked * Add property to job code in open api - Matching query is updated until we search, not while we type. - If select all is selected and unselect one job code, select all is unchecked. - Disable dots menu if is without actions. * Uncheck select all if items change * Check all selected if all are selected
jchavez137
pushed a commit
that referenced
this pull request
Jul 19, 2023
* Working with pagination * Add sort insensitive * Add job code level and parents * Delete job code * Fix delete test * Remove PaginatedJobCodes * Show job codes in list * Request all on clear search * Delete job code by id - Add id in ApiJobCode (ui & api) - Call request to delete in ui * Show toast when job code is deleted * Add confirm message & reload on delete * Fix broken tests * Update open API * Update table job codes - Sort by code - Remove framework name column * Show parents - Add pipe to show parents * Sort by job code level * Add validation to delete a job code - You cannot delete a jobcode with RSDs - You cannot delete a job code with children * Fix create from api * Add error messages on delete job code * Add test new functions back end * Update texts * Update values for MetadataType * Add new tests * Fix broken tests * Remove unused import * Add id property for job code in open api - Requests are without id and responses are with id. * Delete multiple job codes * Improve notifications on delete * Add back to top * Add abstract list * Fix text on action * Clean selected data after delete one or more job codes * Fix table * Disable delete single if select all is checked * Add property to job code in open api - Matching query is updated until we search, not while we type. - If select all is selected and unselect one job code, select all is unchecked. - Disable dots menu if is without actions. * Uncheck select all if items change * Check all selected if all are selected
Corpratespaz
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Working with pagination * Add sort insensitive * Add job code level and parents * Delete job code * Fix delete test * Remove PaginatedJobCodes * Show job codes in list * Request all on clear search * Delete job code by id - Add id in ApiJobCode (ui & api) - Call request to delete in ui * Show toast when job code is deleted * Add confirm message & reload on delete * Fix broken tests * Update open API * Update table job codes - Sort by code - Remove framework name column * Show parents - Add pipe to show parents * Sort by job code level * Add validation to delete a job code - You cannot delete a jobcode with RSDs - You cannot delete a job code with children * Fix create from api * Add error messages on delete job code * Add test new functions back end * Update texts * Update values for MetadataType * Add new tests * Fix broken tests * Remove unused import * Add id property for job code in open api - Requests are without id and responses are with id. * Delete multiple job codes * Improve notifications on delete * Add back to top * Add abstract list * Fix text on action * Clean selected data after delete one or more job codes * Fix table * Disable delete single if select all is checked * Add property to job code in open api - Matching query is updated until we search, not while we type. - If select all is selected and unselect one job code, select all is unchecked. - Disable dots menu if is without actions. * Uncheck select all if items change * Check all selected if all are selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
News
all Paginatedto request all job codes and filter them (API / UI)Changes
queryparameter inallPaginatedmethod to support search.idinApiJobCodebecause ID is used to delete, update and get a specified job code.