fixed bug were it would make multiple xhr requests #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
found that with multiple subscribers to an observable it would remit the execution chain aka send xhr requests. We were using share method but share we were using it incorrectly. After reading the docs, shareReplay method allows for the replaying of values that was returned from the observable without making a costly xhr request for any amount of subscribres.
adding rebase commit
Contributor
Most of this would make an awesome commit message :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found that with multiple subscribers to an observable it would re-emit the execution chain aka send xhr requests for every subscriber. We were using the share method however that only allows to multicast aka allow multiple subscribers but it would still follow the chain and make all the computations it is subscribed to. After reading the docs, the shareReplay method allows for the replaying of values that was returned from the observable without making a costly xhr request for any amount of subscribers.