Adding paypal control #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified documentation to reflect new property `paypal`.
Add `paypal` control support to Android
Add `paypal` control support to iOS
|
well, there's a prop cardDisabled but that doesn't work as well. weird |
|
I'm after this functionality also. Any chance we could get this merged in? |
ysudharsono
added a commit
to ysudharsono/react-native-braintree-dropin-ui
that referenced
this pull request
Oct 26, 2021
A typo in this PR: wgltony#62 The correct config attribute is 'payPal' and not 'paypal' This PR updates the correct usage in the README file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #60
What problem are we trying to solve?
Upon integrating
react-native-braintree-dropin-uiinto an existing React Native project with a pre-existing module that handlesPaypalpayments, we needed a way to disablePaypalpayment method via the Drop-in.Why should we solve it?
While we appreciate that other apps might not need or even require this particular option, its addition would allow developers to have full control over the payment methods they want to use. Currently this module offers the options to disable
googlePay,applePayandCreditCardsbut does not have the same option for disablingPaypal.How do we propose to solve it?
We already have a patch file that adds this option to the react native layer and also adds supporting functionality to both native platforms.
A further change would be to update documentation to detail this change.
What could go wrong?
This option would be disabled by default which would match current expected behaviour.