Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AddressType when using wagmi and viem #2421

Closed

Conversation

technophile-04
Copy link
Contributor

@technophile-04 technophile-04 commented May 24, 2023

Description

While migrating to wagmi V1 in scaffold-eth/scaffold-eth-2#352 the AddressType is not correctly picked (We have configured AddressType as string ) but it still complains type mismatch since its expecting 0x{string}.

Checkout this comment -> scaffold-eth/scaffold-eth-2#352 (comment) for more context

Additional Information

Solution : My assumption is that this is caused due to version mismatch of abiType in viem which uses 0.8.2 and wgmi which uses 0.8.1 ( seems like related to #1712 ), So updated the version of packages using abitype in wagmi to 0.8.2 inline with viem.

Created a direct PR because felt similar to #1712, but please feel free to close this PR in favour of better option, Tysm 🙌

Your ENS/address: shivbhonde.eth

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2023

🦋 Changeset detected

Latest commit: faa4f60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@wagmi/cli Major
@wagmi/core Major
wagmi Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 24, 2023

@technophile-04 is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
abitype@0.8.2 None +0 awkweb

@tmm
Copy link
Member

tmm commented May 26, 2023

this should do it #2441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants