Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: getTransactionCount #2862

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Conversation

marthendalnunes
Copy link
Contributor

@marthendalnunes marthendalnunes commented Oct 14, 2024

Adds missing "optional" flag to blockNumber and blockTag parameters in getTransactionCount docs, and remove the broken embed example.
image


PR-Codex overview

This PR updates the documentation for the getTransactionCount method to clarify that both blockNumber and blockTag parameters are optional. It also removes an example section that was previously included.

Detailed summary

  • Updated blockNumber to indicate it is optional.
  • Updated blockTag to indicate it is optional.
  • Removed the note stating that the transaction count can be used as a nonce.
  • Removed the example section with an iframe.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: 981bcff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 14, 2024

@marthendalnunes is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@jxom jxom merged commit 5fd7ed9 into wevm:main Oct 14, 2024
19 of 32 checks passed
@marthendalnunes marthendalnunes deleted the docs/get-transaction-count branch October 14, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants