Fix for nil assocations in has_snapshot_children on restore

westonganger · Aug 27, 2021 · 0715279 · 0715279
1 parent b2f4a87
commit 0715279
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,7 +3,7 @@ CHANGELOG
 
 - **UNRELEASED**
   * [View Diff](https://github.com/westonganger/active_snapshot/compare/v0.2.1...master)
-  * Nothing yet
+  * [](https://github.com/westonganger/active_snapshot/commit/) - Fix bug on restore for in `has_snapshot_children` method with nil association values
 
 - **v0.2.1** - August 19, 2021
   * [View Diff](https://github.com/westonganger/active_snapshot/compare/v0.2.0...v0.2.1)

diff --git a/lib/active_snapshot/models/concerns/snapshots_concern.rb b/lib/active_snapshot/models/concerns/snapshots_concern.rb
@@ -69,7 +69,8 @@ def children_to_snapshot
           snapshot_children[assoc_name] = {}
 
           if opts.nil?
-            next # skip, nil is allowed value in case has_one/belongs_to is nil, etc.
+            ### nil is allowed value in case has_one/belongs_to is nil, etc.
+            snapshot_children[assoc_name][:records] = []
 
           elsif opts.is_a?(ActiveRecord::Base)
             ### Support belongs_to / has_one

diff --git a/test/dummy_app/app/models/post.rb b/test/dummy_app/app/models/post.rb
@@ -10,6 +10,7 @@ class Post < ActiveRecord::Base
     {
       comments: instance.comments,
       notes: instance.notes,
+      nil_assoc: nil,
     }
   end
 end